Bug 123831 – REGRESSION (r154375): Image is oriented incorrectly

• Status: RESOLVED
• Resolution: FIXED
• Component: Images

[Tim Horton]

Somehow, http://trac.webkit.org/changeset/154375 caused some images to be incorrectly oriented.

Steps to Reproduce:

1. Go to http://www.dpreview.com/galleries/reviewsamples/photos/2736127/pa275561?inalbum=olympus-stylus-1-preview-samples in Safari with ToT WebKit.
2. Click on the eighth picture (the one of the car).
3. Click "original" in the size chooser below. You'll be taken to an ImageDocument.

Expected:

The image should load in the correct orientation, car right-side-up, as it did before this revision.

Actual:

The image loads sideways, and squished.

Unclear to me how this broke without breaking any tests.

<rdar://problem/15352728>

[Gyuyoung Kim]

Let me take a look this issue.

[Gyuyoung Kim]

Created attachment 216272 [details]
Patch

[Gyuyoung Kim]

In r154375, I missed to set shouldRespectImageOrientation value when css-image-orientation is disabled. This patch fixes it.

[Tim Horton]

(In reply to comment #0)
> Unclear to me how this broke without breaking any tests.

Do you plan to resolve this part too?

[Gyuyoung Kim]

(In reply to comment #4)
> (In reply to comment #0)
> > Unclear to me how this broke without breaking any tests.
> 
> Do you plan to resolve this part too?

Let me check why there was no break in layout test.

[WebKit Commit Bot]

Comment on attachment 216272 [details]
Patch

Clearing flags on attachment: 216272

Committed r158900: <http://trac.webkit.org/changeset/158900>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.