Bug 123831 - REGRESSION (r154375): Image is oriented incorrectly
Summary: REGRESSION (r154375): Image is oriented incorrectly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-11-05 14:46 PST by Tim Horton
Modified: 2013-11-07 19:53 PST (History)
8 users (show)

See Also:


Attachments
Patch (3.01 KB, patch)
2013-11-07 01:03 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-11-05 14:46:18 PST
Somehow, http://trac.webkit.org/changeset/154375 caused some images to be incorrectly oriented.

Steps to Reproduce:

1. Go to http://www.dpreview.com/galleries/reviewsamples/photos/2736127/pa275561?inalbum=olympus-stylus-1-preview-samples in Safari with ToT WebKit.
2. Click on the eighth picture (the one of the car).
3. Click "original" in the size chooser below. You'll be taken to an ImageDocument.

Expected:

The image should load in the correct orientation, car right-side-up, as it did before this revision.

Actual:

The image loads sideways, and squished.

Unclear to me how this broke without breaking any tests.

<rdar://problem/15352728>
Comment 1 Gyuyoung Kim 2013-11-05 17:07:10 PST
Let me take a look this issue.
Comment 2 Gyuyoung Kim 2013-11-07 01:03:58 PST
Created attachment 216272 [details]
Patch
Comment 3 Gyuyoung Kim 2013-11-07 01:05:49 PST
In r154375, I missed to set shouldRespectImageOrientation value when css-image-orientation is disabled. This patch fixes it.
Comment 4 Tim Horton 2013-11-07 16:57:49 PST
(In reply to comment #0)
> Unclear to me how this broke without breaking any tests.

Do you plan to resolve this part too?
Comment 5 Gyuyoung Kim 2013-11-07 19:27:05 PST
(In reply to comment #4)
> (In reply to comment #0)
> > Unclear to me how this broke without breaking any tests.
> 
> Do you plan to resolve this part too?

Let me check why there was no break in layout test.
Comment 6 WebKit Commit Bot 2013-11-07 19:53:30 PST
Comment on attachment 216272 [details]
Patch

Clearing flags on attachment: 216272

Committed r158900: <http://trac.webkit.org/changeset/158900>
Comment 7 WebKit Commit Bot 2013-11-07 19:53:33 PST
All reviewed patches have been landed.  Closing bug.