Bug 123829 - Add support for decoding NSStrings
Summary: Add support for decoding NSStrings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-05 14:26 PST by Anders Carlsson
Modified: 2013-11-05 23:14 PST (History)
1 user (show)

See Also:


Attachments
Patch (10.42 KB, patch)
2013-11-05 14:36 PST, Anders Carlsson
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-11-05 14:26:37 PST
Add support for decoding NSStrings
Comment 1 Anders Carlsson 2013-11-05 14:36:59 PST
Created attachment 216082 [details]
Patch
Comment 2 Anders Carlsson 2013-11-05 14:59:01 PST
Committed r158696: <http://trac.webkit.org/changeset/158696>
Comment 3 Alexey Proskuryakov 2013-11-05 23:14:01 PST
This broke an API test. Not rolling out yet, because this doesn't break EWS bots, but please take a look as soon as practical.

Didn't this change need an API test of its own?

[ RUN      ] WebKit2.WKRemoteObjectRegistryTest
2013-11-05 16:31:56.021 TestWebKitAPI[30561:f07] An uncaught exception was raised
2013-11-05 16:31:56.022 TestWebKitAPI[30561:f07] <NSURLRequest http://www.webkit.org/> does not conform to NSSecureCoding
2013-11-05 16:31:56.032 TestWebKitAPI[30561:f07] (
	0   CoreFoundation                      0x00007fff8a426b06 __exceptionPreprocess + 198
	1   libobjc.A.dylib                     0x00007fff8d7533f0 objc_exception_throw + 43
	2   CoreFoundation                      0x00007fff8a4268dc +[NSException raise:format:] + 204
	3   WebKit2                             0x000000010e42e7b4 _ZL12encodeObjectP21WKRemoteObjectEncoderP11objc_object + 244
	4   WebKit2                             0x000000010e42d666 _ZL19createEncodedObjectP21WKRemoteObjectEncoderP11objc_object + 182
	5   WebKit2                             0x000000010e42d3a0 _ZL20encodeToObjectStreamP21WKRemoteObjectEncoderP11objc_object + 64
	6   WebKit2                             0x000000010e42ebb0 _ZL16encodeInvocationP21WKRemoteObjectEncoderP12NSInvocation + 560
	7   WebKit2                             0x000000010e42e75d _ZL12encodeObjectP21WKRemoteObjectEncoderP11objc_object + 157
	8   WebKit2                             0x000000010e42d666 _ZL19createEncodedObjectP21WKRemoteObjectEncoderP11objc_object + 182
	9   WebKit2                             0x000000010e42d480 -[WKRemoteObjectEncoder encodeObject:forKey:] + 80
	10  WebKit2                             0x000000010e337527 -[WKRemoteObjectRegistry _sendInvocation:interface:] + 247
	11  WebKit2                             0x000000010e5cdb06 -[WKRemoteObject forwardInvocation:] + 102
	12  CoreFoundation                      0x00007fff8a415197 ___forwarding___ + 775
	13  CoreFoundation                      0x00007fff8a414e18 _CF_forwarding_prep_0 + 232
	14  TestWebKitAPI                       0x000000010c14f9bf _ZN13TestWebKitAPI39WebKit2_WKRemoteObjectRegistryTest_Test8TestBodyEv + 2383
	15  TestWebKitAPI                       0x000000010c1601da _ZN7testing4Test3RunEv + 154
	16  TestWebKitAPI                       0x000000010c160bfd _ZN7testing8internal12TestInfoImpl3RunEv + 189
	17  TestWebKitAPI                       0x000000010c1617dd _ZN7testing8TestCase3RunEv + 205
	18  TestWebKitAPI                       0x000000010c167627 _ZN7testing8internal12UnitTestImpl11RunAllTestsEv + 935
	19  TestWebKitAPI                       0x000000010c167279 _ZN7testing8UnitTest3RunEv + 25
	20  TestWebKitAPI                       0x000000010c135520 _ZN13TestWebKitAPI15TestsController3runEiPPc + 48
	21  TestWebKitAPI                       0x000000010c156af5 main + 165
	22  libdyld.dylib                       0x00007fff8b8e77e1 start + 0