Bug 123814 – Full width semicolon is wrong in vertical text

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Enrica Casucci]

The unicode character 0xFF1B should always be upright in vertical text.

<rdar://problem/15312541>

[Enrica Casucci]

Created attachment 216065 [details]
Patch

[Benjamin Poulain]

Comment on attachment 216065 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=216065&action=review

> Source/WebCore/platform/graphics/FontGlyphs.cpp:194
>      if (isInRange(character, 0x0FF01, 0x0FF07) || isInRange(character, 0x0FF0A, 0x0FF0C)
> -        || isInRange(character, 0x0FF0E, 0x0FF19) || isInRange(character, 0x0FF1F, 0x0FF3A))
> +        || isInRange(character, 0x0FF0E, 0x0FF19) || character == 0x0FF1B || isInRange(character, 0x0FF1F, 0x0FF3A))
>          return true;

I think you should name 0x0FF1B.

Something like:
    UChar32 fullWidthSemicolon = 0x0FF1B;
    if (... character == fullWidthSemicolon ...

[Enrica Casucci]

(In reply to comment #2)
> (From update of attachment 216065 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=216065&action=review
> 
> > Source/WebCore/platform/graphics/FontGlyphs.cpp:194
> >      if (isInRange(character, 0x0FF01, 0x0FF07) || isInRange(character, 0x0FF0A, 0x0FF0C)
> > -        || isInRange(character, 0x0FF0E, 0x0FF19) || isInRange(character, 0x0FF1F, 0x0FF3A))
> > +        || isInRange(character, 0x0FF0E, 0x0FF19) || character == 0x0FF1B || isInRange(character, 0x0FF1F, 0x0FF3A))
> >          return true;
> 
> I think you should name 0x0FF1B.
> 
> Something like:
>     UChar32 fullWidthSemicolon = 0x0FF1B;
>     if (... character == fullWidthSemicolon ...

This function contains already several other individual characters and ranges according to one of the sub specs of unicode and they are all unnamed, so I'll leave this one unnamed too.

[Build Bot]

Comment on attachment 216065 [details]
Patch

Attachment 216065 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/21158087

New failing tests:
platform/mac/fast/text/vertical-no-sideways.html

[Build Bot]

Created attachment 216074 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 216065 [details]
Patch

Attachment 216065 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/21278016

New failing tests:
platform/mac/fast/text/vertical-no-sideways.html

[Build Bot]

Created attachment 216080 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Enrica Casucci]

Added new test results for mountain lion.
Committed revision 158697.