Bug 123807 - [mips] Make regTx registers match between JSInterfaceJIT and GPRInfo for the MIPS backend.
Summary: [mips] Make regTx registers match between JSInterfaceJIT and GPRInfo for the ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-05 09:07 PST by Julien Brianceau
Modified: 2013-11-05 10:04 PST (History)
3 users (show)

See Also:

Attachments
Make regTx registers match between JSInterfaceJIT and GPRInfo in MIPS backend. (3.04 KB, patch)
2013-11-05 09:19 PST, Julien Brianceau 		no flags Details | Formatted Diff | Diff
Make regTx registers match between JSInterfaceJIT and GPRInfo in MIPS backen (with ASSERT fixed). (3.11 KB, patch)
2013-11-05 09:30 PST, Julien Brianceau 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Brianceau 2013-11-05 09:07:15 PST 
As discussed in https://bugs.webkit.org/show_bug.cgi?id=123799, it would be better for backends that JSInterfaceJIT::regTx and GPRInfo::regTx match the same actual register.
Comment 1 Julien Brianceau 2013-11-05 09:19:56 PST 
Created attachment 216045 [details]
Make regTx registers match between JSInterfaceJIT and GPRInfo in MIPS backend.

It turns out that this patch also fixes many issues seen during run-layout-jsc tests on my MIPS board.
Comment 2 Julien Brianceau 2013-11-05 09:29:37 PST 
Comment on attachment 216045 [details]
Make regTx registers match between JSInterfaceJIT and GPRInfo in MIPS backend.

Forgot to change the ASSERT(reg < 16) in toIndex
Comment 3 Julien Brianceau 2013-11-05 09:30:23 PST 
Created attachment 216047 [details]
Make regTx registers match between JSInterfaceJIT and GPRInfo in MIPS backen (with ASSERT fixed).
Comment 4 Mark Lam 2013-11-05 09:32:30 PST 
Comment on attachment 216047 [details]
Make regTx registers match between JSInterfaceJIT and GPRInfo in MIPS backen (with ASSERT fixed).

r=me
Comment 5 WebKit Commit Bot 2013-11-05 10:03:59 PST 
Comment on attachment 216047 [details]
Make regTx registers match between JSInterfaceJIT and GPRInfo in MIPS backen (with ASSERT fixed).

Clearing flags on attachment: 216047

Committed r158677: <http://trac.webkit.org/changeset/158677>
Comment 6 WebKit Commit Bot 2013-11-05 10:04:02 PST 
All reviewed patches have been landed.  Closing bug.