Bug 123797 - New flakiness dashboard should generate JSON in the background process
Summary: New flakiness dashboard should generate JSON in the background process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Website (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-05 04:03 PST by Ryosuke Niwa
Modified: 2013-11-06 19:47 PST (History)
6 users (show)

See Also:


Attachments
Patch (8.54 KB, patch)
2013-11-05 04:13 PST, Ryosuke Niwa
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-11-05 04:03:01 PST
Don't generate update flakiness state or generate JSONs in the foreground process as that could cause a resource starvation.
Comment 1 Ryosuke Niwa 2013-11-05 04:13:39 PST
Created attachment 216021 [details]
Patch
Comment 2 Alexey Proskuryakov 2013-11-05 23:38:37 PST
Comment on attachment 216021 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=216021&action=review

> Websites/test-results/public/admin/process-builds.php:8
> +function processed_builds($db) {

I think that this function could use a better name. Is it actually called after builds are processed, as the name implies? All or some of them?
Comment 3 Ryosuke Niwa 2013-11-05 23:50:24 PST
(In reply to comment #2)
> (From update of attachment 216021 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=216021&action=review
> 
> > Websites/test-results/public/admin/process-builds.php:8
> > +function processed_builds($db) {
> 
> I think that this function could use a better name. Is it actually called after builds are processed, as the name implies? All or some of them?

Oops, it should read process_latest_five_builds instead.  I apparently forgot to rename :(
Comment 4 Ryosuke Niwa 2013-11-06 19:47:34 PST
Committed r158814: <http://trac.webkit.org/changeset/158814>