Bug 123786 – [WK2] Add a WebKit2 API for Geolocation's highAccuracy

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Benjamin Poulain]

[WK2] Add a WebKit2 API for Geolocation's highAccuracy

[Benjamin Poulain]

Created attachment 215997 [details]
Patch

[Benjamin Poulain]

*** Bug 120136 has been marked as a duplicate of this bug. ***

[EFL EWS Bot]

Comment on attachment 215997 [details]
Patch

Attachment 215997 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/21008003

[Benjamin Poulain]

Created attachment 215998 [details]
Patch

[EFL EWS Bot]

Comment on attachment 215998 [details]
Patch

Attachment 215998 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/20978053

[Benjamin Poulain]

Created attachment 216001 [details]
Patch

[Darin Adler]

Comment on attachment 216001 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=216001&action=review

> Source/WebKit2/UIProcess/WebGeolocationManagerProxy.cpp:101
> +        m_provider.setEnableHighAccuracy(this, isHighAccuracyEnabled());
>          m_provider.startUpdating(this);

Too bad we always have to send two messages here. Seems to me that we could have startUpdating take the high accuracy boolean, and/or combine startUpdating and setEnableHighAccuracy into a single message.

[Benjamin Poulain]

(In reply to comment #7)
> (From update of attachment 216001 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=216001&action=review
> 
> > Source/WebKit2/UIProcess/WebGeolocationManagerProxy.cpp:101
> > +        m_provider.setEnableHighAccuracy(this, isHighAccuracyEnabled());
> >          m_provider.startUpdating(this);
> 
> Too bad we always have to send two messages here. Seems to me that we could have startUpdating take the high accuracy boolean, and/or combine startUpdating and setEnableHighAccuracy into a single message.

Most system do not handle setEnableHighAccuracy() and the callback function will be null. I could make a new startUpdating but I don't think it is worth is since the other API is already widely used.

[Benjamin Poulain]

Comment on attachment 216001 [details]
Patch

Clearing flags on attachment: 216001

Committed r158689: <http://trac.webkit.org/changeset/158689>

[Benjamin Poulain]

All reviewed patches have been landed.  Closing bug.

[Ryosuke Niwa]

This patch caused all tests to start crashing:
e.g. 
http://build.webkit.org/builders/Apple%20MountainLion%20Debug%20WK2%20%28Tests%29/builds/13947
http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r158689%20(13947)/results.html