Bug 123786 - [WK2] Add a WebKit2 API for Geolocation's highAccuracy
Summary: [WK2] Add a WebKit2 API for Geolocation's highAccuracy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
: 120136 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-11-04 20:55 PST by Benjamin Poulain
Modified: 2013-11-05 14:17 PST (History)
10 users (show)

See Also:

Attachments
Patch (43.79 KB, patch)
2013-11-04 21:06 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (43.76 KB, patch)
2013-11-04 21:18 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (43.94 KB, patch)
2013-11-04 21:43 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2013-11-04 20:55:12 PST 
[WK2] Add a WebKit2 API for Geolocation's highAccuracy
Comment 1 Benjamin Poulain 2013-11-04 21:06:25 PST 
Created attachment 215997 [details]
Patch
Comment 2 Benjamin Poulain 2013-11-04 21:08:46 PST 
*** Bug 120136 has been marked as a duplicate of this bug. ***
Comment 3 EFL EWS Bot 2013-11-04 21:16:05 PST 
Comment on attachment 215997 [details]
Patch

Attachment 215997 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/21008003
Comment 4 Benjamin Poulain 2013-11-04 21:18:14 PST 
Created attachment 215998 [details]
Patch
Comment 5 EFL EWS Bot 2013-11-04 21:25:46 PST 
Comment on attachment 215998 [details]
Patch

Attachment 215998 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/20978053
Comment 6 Benjamin Poulain 2013-11-04 21:43:06 PST 
Created attachment 216001 [details]
Patch
Comment 7 Darin Adler 2013-11-05 09:04:01 PST 
Comment on attachment 216001 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=216001&action=review

> Source/WebKit2/UIProcess/WebGeolocationManagerProxy.cpp:101
> +        m_provider.setEnableHighAccuracy(this, isHighAccuracyEnabled());
>          m_provider.startUpdating(this);

Too bad we always have to send two messages here. Seems to me that we could have startUpdating take the high accuracy boolean, and/or combine startUpdating and setEnableHighAccuracy into a single message.
Comment 8 Benjamin Poulain 2013-11-05 13:13:46 PST 
(In reply to comment #7)
> (From update of attachment 216001 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=216001&action=review
> 
> > Source/WebKit2/UIProcess/WebGeolocationManagerProxy.cpp:101
> > +        m_provider.setEnableHighAccuracy(this, isHighAccuracyEnabled());
> >          m_provider.startUpdating(this);
> 
> Too bad we always have to send two messages here. Seems to me that we could have startUpdating take the high accuracy boolean, and/or combine startUpdating and setEnableHighAccuracy into a single message.

Most system do not handle setEnableHighAccuracy() and the callback function will be null. I could make a new startUpdating but I don't think it is worth is since the other API is already widely used.
Comment 9 Benjamin Poulain 2013-11-05 13:15:07 PST 
Comment on attachment 216001 [details]
Patch

Clearing flags on attachment: 216001

Committed r158689: <http://trac.webkit.org/changeset/158689>
Comment 10 Benjamin Poulain 2013-11-05 13:15:09 PST 
All reviewed patches have been landed.  Closing bug.