Bug 123775 - IDB: Make opening/establishing a database asynchronous
Summary: IDB: Make opening/establishing a database asynchronous
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-04 19:22 PST by Brady Eidson
Modified: 2013-11-04 21:18 PST (History)
3 users (show)

See Also:

Attachments
Patch v1 (18.29 KB, patch)
2013-11-04 20:03 PST, Brady Eidson 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2013-11-04 19:22:22 PST 
IDB: Make opening/establishing a database asynchronous

Currently opening a database involves main thread I/O.

Let's make it asynchronous instead.

The LevelDB implementation will still be main thread synchronous.
Comment 1 Brady Eidson 2013-11-04 20:03:12 PST 
Created attachment 215987 [details]
Patch v1
Comment 2 WebKit Commit Bot 2013-11-04 20:04:09 PST 
Attachment 215987 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/indexeddb/IDBBackingStoreInterface.h', u'Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp', u'Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.h', u'Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp', u'Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h']" exit_code: 1
Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:183:  The parameter name "metadata" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Brady Eidson 2013-11-04 20:06:10 PST 
(In reply to comment #2)
> Attachment 215987 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/indexeddb/IDBBackingStoreInterface.h', u'Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp', u'Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.h', u'Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp', u'Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h']" exit_code: 1
> Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:183:  The parameter name "metadata" adds no information, so it should be removed.  [readability/parameter_name] [5]
> Total errors found: 1 in 6 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

Fixed locally.
Comment 4 Andreas Kling 2013-11-04 21:01:56 PST 
Comment on attachment 215987 [details]
Patch v1 

View in context: https://bugs.webkit.org/attachment.cgi?id=215987&action=review

r=me

> Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:450
> +            RefPtr<IDBDatabaseError> error;

This looks unused.
Comment 5 Brady Eidson 2013-11-04 21:04:30 PST 
(In reply to comment #4)
> (From update of attachment 215987 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=215987&action=review
> 
> r=me
> 
> > Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:450
> > +            RefPtr<IDBDatabaseError> error;
> 
> This looks unused.

INDEED!
Comment 6 Brady Eidson 2013-11-04 21:06:37 PST 
http://trac.webkit.org/changeset/158641
Comment 7 Brady Eidson 2013-11-04 21:18:33 PST 
And that additional review feedback in http://trac.webkit.org/changeset/158642