Bug 123758 - [Win] Use VersionStamper for official builds
Summary: [Win] Use VersionStamper for official builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-11-04 15:01 PST by Brent Fulgham
Modified: 2013-11-04 15:24 PST (History)
0 users

See Also:


Attachments
Patch (2.54 KB, patch)
2013-11-04 15:05 PST, Brent Fulgham
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2013-11-04 15:01:46 PST
When we revised the build system for VS2010, the step that would run "VersionStamper" to set the shipping version number on the DLL was lost. This causes some internal stuff to break when we attempt to build for external users.

This patch simply puts the missing command back into our post-build scripts so that the right thing happens when building an official release.
Comment 1 Brent Fulgham 2013-11-04 15:01:58 PST
<rdar://problem/15373550>
Comment 2 Brent Fulgham 2013-11-04 15:05:59 PST
Created attachment 215957 [details]
Patch
Comment 3 Brent Fulgham 2013-11-04 15:24:37 PST
Committed r158602: <http://trac.webkit.org/changeset/158602>