Bug 123745 - Make LiveNodeListBase use Elements instead of Nodes
Summary: Make LiveNodeListBase use Elements instead of Nodes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-11-04 10:12 PST by Antti Koivisto
Modified: 2022-08-02 09:14 PDT (History)
13 users (show)

See Also:

Attachments
patch (22.25 KB, patch)
2013-11-04 10:22 PST, Antti Koivisto 		andersca: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 (541.92 KB, application/zip)
2013-11-04 12:12 PST, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion (599.71 KB, application/zip)
2013-11-04 12:18 PST, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion (582.47 KB, application/zip)
2013-11-04 12:44 PST, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-11-04 10:12:32 PST 
With ChildNodeList moved away it can only contain Elements.
Comment 1 Antti Koivisto 2013-11-04 10:22:18 PST 
Created attachment 215929 [details]
patch
Comment 2 Build Bot 2013-11-04 12:12:36 PST 
Comment on attachment 215929 [details]
patch

Attachment 215929 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/19578788

New failing tests:
traversal/hixie-node-iterator/002.xml
traversal/stay-within-root.html
http/tests/misc/acid3.html
traversal/moz-bug590771.html
traversal/moz-mutations-3.html
Comment 3 Build Bot 2013-11-04 12:12:38 PST 
Created attachment 215939 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 4 Build Bot 2013-11-04 12:18:30 PST 
Comment on attachment 215929 [details]
patch

Attachment 215929 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/19628811

New failing tests:
traversal/hixie-node-iterator/002.xml
traversal/stay-within-root.html
http/tests/misc/acid3.html
traversal/moz-bug590771.html
traversal/moz-mutations-3.html
Comment 5 Build Bot 2013-11-04 12:18:32 PST 
Created attachment 215941 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 6 Build Bot 2013-11-04 12:44:19 PST 
Comment on attachment 215929 [details]
patch

Attachment 215929 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/19588828

New failing tests:
traversal/hixie-node-iterator/002.xml
traversal/stay-within-root.html
http/tests/misc/acid3.html
traversal/moz-bug590771.html
traversal/moz-mutations-3.html
Comment 7 Build Bot 2013-11-04 12:44:21 PST 
Created attachment 215946 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 8 Antti Koivisto 2013-11-04 13:29:56 PST 
https://trac.webkit.org/r158587 (with NodeIterator fixed)
Comment 9 Ahmad Saleem 2022-08-02 04:29:14 PDT 
I see this landed but not backed out.

https://github.com/WebKit/WebKit/commit/873a3aa7ffbf7b630767738398648ad7a9f82b9c

Can this be marked as "RESOLVED FIXED"? Thanks1
Comment 10 Radar WebKit Bug Importer 2022-08-02 09:14:16 PDT 
<rdar://problem/97984311>