Bug 123743 - [CSS Shapes] image valued shape element margin can cause an ASSERT fail
Summary: [CSS Shapes] image valued shape element margin can cause an ASSERT fail
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hans Muller
URL:
Keywords:
Depends on:
Blocks: 116348
  Show dependency tree / graph
 
Reported: 2013-11-04 09:24 PST by Hans Muller
Modified: 2013-11-04 14:37 PST (History)
5 users (show)

See Also:

Attachments
Test case. (412 bytes, text/html)
2013-11-04 11:02 PST, Hans Muller 		no flags Details
Patch (4.83 KB, patch)
2013-11-04 12:16 PST, Hans Muller 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Muller 2013-11-04 09:24:41 PST 
Specifying a non-zero shape-margin value for an image with an above shape-image-threshold pixels  0,0 (for example) will cause an assertion failure.
Comment 1 Hans Muller 2013-11-04 11:02:43 PST 
Created attachment 215932 [details]
Test case.

The attached test case demonstrates that the problem is due to specifying a non-zero margin (not shape-margin) for the shape-outside element.
Comment 2 Hans Muller 2013-11-04 12:16:44 PST 
Created attachment 215940 [details]
Patch

When margin-top is specified for a shape's element, the Y coordinates passed to RasterShapeIntervals::getExcludedIntervals() may be negative. This is because the incoming logical coordinates are relative to the content or padding box, depending on the box-sizing property. The RasterShape::getExcludedIntervals() method now clips the incoming Y coordinates to the shape's bounds.
Comment 3 WebKit Commit Bot 2013-11-04 14:37:51 PST 
Comment on attachment 215940 [details]
Patch

Clearing flags on attachment: 215940

Committed r158596: <http://trac.webkit.org/changeset/158596>
Comment 4 WebKit Commit Bot 2013-11-04 14:37:53 PST 
All reviewed patches have been landed.  Closing bug.