Bug 123737 (code) - [Texmap] Removing of a redundant code
Summary: [Texmap] Removing of a redundant code
Status: RESOLVED FIXED
Alias: code
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-11-04 04:39 PST by Przemyslaw Szymanski
Modified: 2019-09-25 20:44 PDT (History)
7 users (show)

See Also:

Attachments
Redundant code (2.26 KB, patch)
2013-11-04 04:44 PST, Przemyslaw Szymanski 		noam: review+
noam: commit-queue-
Details | Formatted Diff | Diff
Redundant code (2.28 KB, patch)
2013-11-04 05:42 PST, Przemyslaw Szymanski 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Przemyslaw Szymanski 2013-11-04 04:39:23 PST 
After few refactor patches it is an unused code which can be removed
Comment 1 Przemyslaw Szymanski 2013-11-04 04:44:30 PST 
Created attachment 215912 [details]
Redundant code
Comment 2 Noam Rosenthal 2013-11-04 05:04:28 PST 
Comment on attachment 215912 [details]
Redundant code

View in context: https://bugs.webkit.org/attachment.cgi?id=215912&action=review

> Source/WebCore/ChangeLog:3
> +        [Texmap] Removing a redundant code

Remove redundant calls in CoordinatedGraphicsScene

> Source/WebCore/ChangeLog:8
> +        It is some unused code left after few refactoring patches.

It is -> Removing
Comment 3 Przemyslaw Szymanski 2013-11-04 05:42:42 PST 
Created attachment 215914 [details]
Redundant code
Comment 4 Przemyslaw Szymanski 2013-11-04 05:43:49 PST 
(In reply to comment #2)
> (From update of attachment 215912 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=215912&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        [Texmap] Removing a redundant code
> 
> Remove redundant calls in CoordinatedGraphicsScene
> 
> > Source/WebCore/ChangeLog:8
> > +        It is some unused code left after few refactoring patches.
> 
> It is -> Removing

Thank you for your review. Changes updated
Comment 5 WebKit Commit Bot 2013-11-04 06:56:29 PST 
Comment on attachment 215914 [details]
Redundant code

Clearing flags on attachment: 215914

Committed r158574: <http://trac.webkit.org/changeset/158574>
Comment 6 WebKit Commit Bot 2013-11-04 06:56:31 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Keith Miller 2019-09-25 19:33:27 PDT 
Reopening to attach new patch.
Comment 8 Keith Miller 2019-09-25 20:43:06 PDT 
Ugh, WebKit-patch freaked out and reopened this... sorry for the spam.
Comment 9 Radar WebKit Bug Importer 2019-09-25 20:44:18 PDT 
<rdar://problem/55730145>