RESOLVED FIXED123725
Use RenderAncestorIterator in a couple of places. 
https://bugs.webkit.org/show_bug.cgi?id=123725
Summary Use RenderAncestorIterator in a couple of places.
Andreas Kling
Reported 2013-11-04 01:37:48 PST
Use RenderAncestorIterator in a couple of places.
Attachments
Patch (8.37 KB, patch)
2013-11-04 01:46 PST, Andreas Kling 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-11-04 01:46:00 PST
Created attachment 215897 [details] Patch
Antti Koivisto
Comment 2 2013-11-04 04:00:04 PST
Comment on attachment 215897 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215897&action=review > Source/WebCore/rendering/RenderRegion.cpp:405 > + if (auto closestFlowThreadAncestor = ancestorsOfType<RenderNamedFlowThread>(*this).first()) { > + m_parentNamedFlowThread = &*closestFlowThreadAncestor; > + // Do not take into account a region that links a flow with itself. The dependency > + // cannot change, so it is not worth adding it to the list. > + if (m_flowThread == m_parentNamedFlowThread) > + m_flowThread = nullptr; > + } else > + m_parentNamedFlowThread = nullptr; > } I would reverse the test and do early return in the else case.
Andreas Kling
Comment 3 2013-11-04 16:11:12 PST
Committed r158611: <http://trac.webkit.org/changeset/158611>
Note You need to log in before you can comment on or make changes to this bug.