Bug 123718 - Add an ancestor renderer iterator.
Summary: Add an ancestor renderer iterator.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
Depends on:
Reported: 2013-11-03 18:46 PST by Andreas Kling
Modified: 2013-11-04 00:44 PST (History)
6 users (show)

See Also:

Patch (28.28 KB, patch)
2013-11-03 19:11 PST, Andreas Kling
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-11-03 18:46:50 PST
We should have ancestorsOfType<RenderFoo>() iterators, too.
Comment 1 Andreas Kling 2013-11-03 19:11:11 PST
Created attachment 215884 [details]
Comment 2 WebKit Commit Bot 2013-11-03 19:14:12 PST
Attachment 215884 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/rendering/RenderAncestorIterator.h', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBlockFlow.cpp', u'Source/WebCore/rendering/RenderBlockFlow.h', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderFrameSet.cpp', u'Source/WebCore/rendering/RenderFrameSet.h', u'Source/WebCore/rendering/RenderIterator.h', u'Source/WebCore/rendering/RenderTextFragment.cpp', u'Source/WebCore/rendering/RenderTextFragment.h']" exit_code: 1
Source/WebCore/rendering/RenderIterator.h:266:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 14 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2013-11-04 00:44:29 PST
Committed r158561: <http://trac.webkit.org/changeset/158561>