Bug 123714 – RenderTextFragment: Tighten first-letter logic.

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Andreas Kling]

RenderTextFragment: Tighten first-letter logic.

[Andreas Kling]

Created attachment 215879 [details]
Patch

[Antti Koivisto]

Comment on attachment 215879 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215879&action=review

> Source/WebCore/editing/TextIterator.cpp:672
> -static inline RenderText* firstRenderTextInFirstLetter(RenderObject* firstLetter)
> +static inline RenderText* firstRenderTextInFirstLetter(RenderBoxModelObject* firstLetter)
>  {
>      if (!firstLetter)
> -        return 0;
> +        return nullptr;

Maybe you could just remove this helper? Only one call site needs the null test.

[Andreas Kling]

(In reply to comment #2)
> (From update of attachment 215879 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=215879&action=review
> 
> > Source/WebCore/editing/TextIterator.cpp:672
> > -static inline RenderText* firstRenderTextInFirstLetter(RenderObject* firstLetter)
> > +static inline RenderText* firstRenderTextInFirstLetter(RenderBoxModelObject* firstLetter)
> >  {
> >      if (!firstLetter)
> > -        return 0;
> > +        return nullptr;
> 
> Maybe you could just remove this helper? Only one call site needs the null test.

I like that it provides a home for the FIXME. I don't know what to do about that FIXME, otherwise I'd be fixing it. :(

[Andreas Kling]

Committed r158551: <http://trac.webkit.org/changeset/158551>