RESOLVED FIXED123704
Switch createContextualFragment to element iterator 
https://bugs.webkit.org/show_bug.cgi?id=123704
Summary Switch createContextualFragment to element iterator
Antti Koivisto
Reported 2013-11-03 04:26:56 PST
more iterator
Attachments
patch (3.65 KB, patch)
2013-11-03 04:30 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
better patch (6.39 KB, patch)
2013-11-03 06:43 PST, Antti Koivisto 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2013-11-03 04:30:56 PST
Created attachment 215865 [details] patch
Antti Koivisto
Comment 2 2013-11-03 06:43:28 PST
Created attachment 215866 [details] better patch
Andreas Kling
Comment 3 2013-11-03 12:14:53 PST
Comment on attachment 215866 [details] better patch View in context: https://bugs.webkit.org/attachment.cgi?id=215866&action=review r=me > Source/WebCore/editing/FrameSelection.cpp:1967 > + if (!contentDocument) > + continue; This looks new. Sneaky.
Antti Koivisto
Comment 4 2013-11-03 12:18:25 PST
https://trac.webkit.org/r158537
Chris Dumez
Comment 5 2014-11-03 21:52:50 PST
Comment on attachment 215866 [details] better patch View in context: https://bugs.webkit.org/attachment.cgi?id=215866&action=review > Source/WebCore/editing/markup.cpp:913 > + collectElementsToRemoveFromFragment(element); This statement has no effect as the result value is being ignored.
Antti Koivisto
Comment 6 2014-11-04 07:17:02 PST
Comment on attachment 215866 [details] better patch View in context: https://bugs.webkit.org/attachment.cgi?id=215866&action=review >> Source/WebCore/editing/markup.cpp:913 >> + collectElementsToRemoveFromFragment(element); > > This statement has no effect as the result value is being ignored. Good catch!
Chris Dumez
Comment 7 2014-11-04 08:42:40 PST
(In reply to comment #6) > Comment on attachment 215866 [details] > better patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=215866&action=review > > >> Source/WebCore/editing/markup.cpp:913 > >> + collectElementsToRemoveFromFragment(element); > > > > This statement has no effect as the result value is being ignored. > > Good catch! The thing is that I am not sure it is actually possible to have an <html> here. I have been trying to test the problem but I cannot get createFragmentForInnerOuterHTML() to return an <html> as first child in the DocumentFragment, despite the input having an <html> tag: http://jsfiddle.net/2qevwvs3/8/
Note You need to log in before you can comment on or make changes to this bug.