Bug 123699 – [CSSRegions] Use auto keyword to clean-up for loops

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Mihnea Ovidenie]

Start using auto keyword in for loops instead of long iterators.

[Mihnea Ovidenie]

Created attachment 215853 [details]
Patch

[Anders Carlsson]

Comment on attachment 215853 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215853&action=review

> Source/WebCore/rendering/RenderRegion.cpp:538
> +    for (auto iter = m_renderObjectRegionStyle.begin(), end = m_renderObjectRegionStyle.end(); iter != end; ++iter) {

I think you should change the other loops to have the end iterator in a local variable as well, since you're changing them anyway.

[Mihnea Ovidenie]

(In reply to comment #2)
> (From update of attachment 215853 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=215853&action=review
> 
> > Source/WebCore/rendering/RenderRegion.cpp:538
> > +    for (auto iter = m_renderObjectRegionStyle.begin(), end = m_renderObjectRegionStyle.end(); iter != end; ++iter) {
> 
> I think you should change the other loops to have the end iterator in a local variable as well, since you're changing them anyway.

Sure, thanks for the review.

[Mihnea Ovidenie]

Created attachment 215891 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 215891 [details]
Patch for landing

Clearing flags on attachment: 215891

Committed r158559: <http://trac.webkit.org/changeset/158559>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.