Bug 123686 - Cleanup OpenTypeUtilities
Summary: Cleanup OpenTypeUtilities
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Patrick R. Gansterer
Depends on:
Reported: 2013-11-02 14:07 PDT by Patrick R. Gansterer
Modified: 2013-11-02 20:22 PDT (History)
1 user (show)

See Also:

Patch (10.01 KB, patch)
2013-11-02 14:12 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2013-11-02 14:07:48 PDT
Cleanup OpenTypeUtilities
Comment 1 Patrick R. Gansterer 2013-11-02 14:12:36 PDT
Created attachment 215831 [details]
Comment 2 Darin Adler 2013-11-02 19:58:05 PDT
Comment on attachment 215831 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=215831&action=review

Looks OK.

> Source/WebCore/ChangeLog:3
> +        Cleanup OpenTypeUtilities

Cleanup is a noun. The verb is “clean up”.

> Source/WebCore/platform/graphics/wince/FontCustomPlatformData.cpp:72
>  std::unique_ptr<FontCustomPlatformData> createFontCustomPlatformData(const SharedBuffer* buffer)

If you can assert that the buffer pointer is non-null, that’s a clue that the argument should be a reference instead of a pointer. Would be nice to change that at some point.
Comment 3 WebKit Commit Bot 2013-11-02 20:22:56 PDT
Comment on attachment 215831 [details]

Clearing flags on attachment: 215831

Committed r158519: <http://trac.webkit.org/changeset/158519>
Comment 4 WebKit Commit Bot 2013-11-02 20:22:57 PDT
All reviewed patches have been landed.  Closing bug.