RESOLVED FIXED 123686
Cleanup OpenTypeUtilities 
https://bugs.webkit.org/show_bug.cgi?id=123686
Summary Cleanup OpenTypeUtilities
Patrick R. Gansterer
Reported 2013-11-02 14:07:48 PDT
Cleanup OpenTypeUtilities
Attachments
Patch (10.01 KB, patch)
2013-11-02 14:12 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2013-11-02 14:12:36 PDT
Created attachment 215831 [details] Patch
Darin Adler
Comment 2 2013-11-02 19:58:05 PDT
Comment on attachment 215831 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215831&action=review Looks OK. > Source/WebCore/ChangeLog:3 > + Cleanup OpenTypeUtilities Cleanup is a noun. The verb is “clean up”. > Source/WebCore/platform/graphics/wince/FontCustomPlatformData.cpp:72 > std::unique_ptr<FontCustomPlatformData> createFontCustomPlatformData(const SharedBuffer* buffer) If you can assert that the buffer pointer is non-null, that’s a clue that the argument should be a reference instead of a pointer. Would be nice to change that at some point.
WebKit Commit Bot
Comment 3 2013-11-02 20:22:56 PDT
Comment on attachment 215831 [details] Patch Clearing flags on attachment: 215831 Committed r158519: <http://trac.webkit.org/changeset/158519>
WebKit Commit Bot
Comment 4 2013-11-02 20:22:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.