Bug 123674 - Fix MSVC warning about unary minus operator
Summary: Fix MSVC warning about unary minus operator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-02 10:59 PDT by Patrick R. Gansterer
Modified: 2013-11-02 20:15 PDT (History)
1 user (show)

See Also:


Attachments
Patch (2.25 KB, patch)
2013-11-02 11:03 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2013-11-02 10:59:49 PDT
Fix MSVC warning about unary minus operator
Comment 1 Patrick R. Gansterer 2013-11-02 11:03:20 PDT
Created attachment 215817 [details]
Patch
Comment 2 Darin Adler 2013-11-02 19:48:13 PDT
Comment on attachment 215817 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215817&action=review

> Source/JavaScriptCore/jit/Repatch.cpp:864
> +                stubJit.loadPtr(MacroAssembler::Address(scratchGPR3, -static_cast<ptrdiff_t>(offset + sizeof(JSValue) + sizeof(void*))), scratchGPR2);
> +                stubJit.storePtr(scratchGPR2, MacroAssembler::Address(scratchGPR1, -static_cast<ptrdiff_t>(offset + sizeof(JSValue) + sizeof(void*))));

I think ssize_t would be better than ptrdiff_t here, but maybe Windows doesn’t even have that type.
Comment 3 WebKit Commit Bot 2013-11-02 20:15:07 PDT
Comment on attachment 215817 [details]
Patch

Clearing flags on attachment: 215817

Committed r158516: <http://trac.webkit.org/changeset/158516>
Comment 4 WebKit Commit Bot 2013-11-02 20:15:08 PDT
All reviewed patches have been landed.  Closing bug.