Bug 123673 - Make AuthenticationClient a base class of ResourceHandle for all ports
Summary: Make AuthenticationClient a base class of ResourceHandle for all ports
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-02 10:52 PDT by Patrick R. Gansterer
Modified: 2018-11-16 08:49 PST (History)
3 users (show)

See Also:

Attachments
Patch (3.91 KB, patch)
2013-11-02 10:56 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Patch (3.62 KB, patch)
2013-11-03 07:02 PST, Patrick R. Gansterer 		beidson: review-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2013-11-02 10:52:14 PDT 
Make AuthenticationClient a base class of ResourceHandle for all ports
Comment 1 Patrick R. Gansterer 2013-11-02 10:56:19 PDT 
Created attachment 215816 [details]
Patch
Comment 2 Darin Adler 2013-11-02 19:46:17 PDT 
Comment on attachment 215816 [details]
Patch

I’m not sure this is a good change. On the one hand, it’s nice to remove an unneeded #if, but on the other hand, I’m pretty sure that we’re now compiling dead code, since if anything was calling shouldUseCredentialStorage, we would not have compiled before. Implementing that function is not valuable. It would be better to not implement it rather than having code that is never called. Same for didReceiveAuthenticationChallenge. For the three virtual functions, I am unsure whether empty implementations are safe to have around.
Comment 3 Patrick R. Gansterer 2013-11-03 07:02:25 PST 
Created attachment 215867 [details]
Patch
Comment 4 Brady Eidson 2016-05-16 22:41:15 PDT 
Comment on attachment 215867 [details]
Patch

This is obsolete in a number of ways, one of which being that ResourceHandle is no longer the sole network loading class.
Comment 5 Rob Buis 2018-11-15 12:27:53 PST 
It seems AuthenticationClient these days is a base class of ResourceHandle for all ports, should we close this?
Comment 6 Darin Adler 2018-11-16 08:49:34 PST 
Sure, let's close it.