Bug 123669 – Implement generateKey for HMAC and AES-CBC

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Alexey Proskuryakov]

Implement generateKey for HMAC and AES-CBC.

[Alexey Proskuryakov]

Created attachment 215815 [details]
proposed patch

[WebKit Commit Bot]

Attachment 215815 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/crypto/subtle/aes-cbc-generate-key-expected.txt', u'LayoutTests/crypto/subtle/aes-cbc-generate-key.html', u'LayoutTests/crypto/subtle/hmac-generate-key-expected.txt', u'LayoutTests/crypto/subtle/hmac-generate-key.html', u'LayoutTests/crypto/subtle/sha-1-expected.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/js/JSCryptoAlgorithmDictionary.cpp', u'Source/WebCore/bindings/js/JSDOMBinding.cpp', u'Source/WebCore/bindings/js/JSDOMBinding.h', u'Source/WebCore/bindings/js/JSSubtleCryptoCustom.cpp', u'Source/WebCore/crypto/CryptoAlgorithmAesKeyGenParams.h', u'Source/WebCore/crypto/CryptoKey.cpp', u'Source/WebCore/crypto/CryptoKey.h', u'Source/WebCore/crypto/CryptoKeyAES.cpp', u'Source/WebCore/crypto/CryptoKeyAES.h', u'Source/WebCore/crypto/CryptoKeyMac.cpp', u'Source/WebCore/crypto/SubtleCrypto.idl', u'Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp', u'Source/WebCore/crypto/algorithms/CryptoAlgorithmHMAC.cpp', u'Source/WebCore/crypto/keys/CryptoKeyHMAC.cpp', u'Source/WebCore/crypto/keys/CryptoKeyHMAC.h', u'Source/WebCore/crypto/mac/CryptoAlgorithmAES_CBCMac.cpp', u'Source/WebCore/crypto/mac/CryptoAlgorithmHMACMac.cpp']" exit_code: 1
Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:58:  CryptoAlgorithmAES_CBC::generateKey is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebCore/crypto/CryptoKeyMac.cpp:32:  Missing spaces around /  [whitespace/operators] [3]
Total errors found: 2 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 215815 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215815&action=review

> Source/WebCore/crypto/keys/CryptoKeyHMAC.h:44
> +    // If lengthBytes is 0, recommended length is used, which is the size of the associated hash function's block size.

Needs an article before “recommended”.

[Alexey Proskuryakov]

Created attachment 215846 [details]
patch for landing

[WebKit Commit Bot]

Comment on attachment 215846 [details]
patch for landing

Clearing flags on attachment: 215846

Committed r158526: <http://trac.webkit.org/changeset/158526>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 123744

[Alexey Proskuryakov]

Created attachment 215928 [details]
patch for re-landing

[WebKit Commit Bot]

Comment on attachment 215928 [details]
patch for re-landing

Rejecting attachment 215928 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 215928, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
pply', '--force']" exit_code: 29 cwd: /Volumes/Data/EWS/WebKit

Parsed 24 diffs from patch file(s).
cp: Source/WebCore/crypto/CryptoAlgorithmAesKeyGenParams.h: No such file or directory
Failed to copy Source/WebCore/crypto/CryptoAlgorithmAesKeyGenParams.h Source/WebCore/crypto/CryptoAlgorithmAesKeyGenParams.h. at /Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply line 436.

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 29 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/19648792

[Alexey Proskuryakov]

Sigh. Filed bug 123747 for commit queue failure, will re-land manually.

[Alexey Proskuryakov]

Re-landed in <http://trac.webkit.org/r158582>.