Bug 123664 - Generated color wheel displays incorrectly (regressed in r155567)
Summary: Generated color wheel displays incorrectly (regressed in r155567)
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Filip Pizlo
Keywords: InRadar
Depends on:
Reported: 2013-11-02 06:46 PDT by Antoine Quint
Modified: 2013-11-03 20:22 PST (History)
10 users (show)

See Also:

Color wheel test case (1.47 KB, text/html)
2013-11-02 06:46 PDT, Antoine Quint
no flags Details
the patch (3.84 KB, patch)
2013-11-03 18:12 PST, Filip Pizlo
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2013-11-02 06:46:56 PDT
Created attachment 215807 [details]
Color wheel test case

The attached test case where we draw a color wheel programmatically using the CanvasRenderingContext2D API renders incorrectly on ToT where it used to work fine. Regressing shows that this rendered as expected as of r155565 and incorrectly with r155567, r155567 was untested but given it's a Windows-specific fix, it's likely that this regressed in http://trac.webkit.org/changeset/155567, a code change introduced to fix https://bugs.webkit.org/show_bug.cgi?id=121141.
Comment 1 Radar WebKit Bug Importer 2013-11-02 06:47:10 PDT
Comment 2 Filip Pizlo 2013-11-02 10:08:47 PDT
Looks like a fun bug!
Comment 3 Filip Pizlo 2013-11-03 17:48:22 PST
Yeah, it's obviously a miscompile in hsl2rgb().
Comment 4 Filip Pizlo 2013-11-03 18:12:33 PST
Created attachment 215883 [details]
the patch
Comment 5 Filip Pizlo 2013-11-03 20:22:44 PST
Landed in http://trac.webkit.org/changeset/158556