RESOLVED FIXED 123660
[Cocoa] Add WKNSDictionary 
https://bugs.webkit.org/show_bug.cgi?id=123660
Summary [Cocoa] Add WKNSDictionary
mitz
Reported 2013-11-02 00:59:42 PDT
[Cocoa] Add WKNSDictionary
Attachments
Add WKNSDictionary (11.63 KB, patch)
2013-11-02 01:06 PDT, mitz 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2013-11-02 01:06:26 PDT
Created attachment 215802 [details] Add WKNSDictionary
WebKit Commit Bot
Comment 2 2013-11-02 01:07:41 PDT
Attachment 215802 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/Cocoa/APIObject.mm', u'Source/WebKit2/Shared/Cocoa/WKNSDictionary.h', u'Source/WebKit2/Shared/Cocoa/WKNSDictionary.mm', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj']" exit_code: 1 Source/WebKit2/Shared/Cocoa/WKNSDictionary.h:34: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2013-11-02 07:32:26 PDT
Comment on attachment 215802 [details] Add WKNSDictionary View in context: https://bugs.webkit.org/attachment.cgi?id=215802&action=review > Source/WebKit2/Shared/Cocoa/WKNSDictionary.mm:48 > +// -initWithObjects:forKeys:count: not implemented, because it should never be called. In debug builds, could you add an implementation with an ASSERT_NOT_REACHED?
mitz
Comment 4 2013-11-02 09:37:54 PDT
Comment on attachment 215802 [details] Add WKNSDictionary View in context: https://bugs.webkit.org/attachment.cgi?id=215802&action=review >> Source/WebKit2/Shared/Cocoa/WKNSDictionary.mm:48 >> +// -initWithObjects:forKeys:count: not implemented, because it should never be called. > > In debug builds, could you add an implementation with an ASSERT_NOT_REACHED? OK. I didn’t because NSDictionary has an implementation that raises an exception.
mitz
Comment 5 2013-11-02 09:41:17 PDT
Committed <http://trac.webkit.org/r158489>.
Note You need to log in before you can comment on or make changes to this bug.