Bug 123648 – Removing MediaStreamTrackVector and MediaStreamSourceVector typedefs

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Thiago de Barros Lacerda]

Talking with Eric Carlson we agreed that those reduce code readability.

[Thiago de Barros Lacerda]

Created attachment 215781 [details]
Patch

[Eric Carlson]

Comment on attachment 215781 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215781&action=review

This looks good, thanks for doing it! 

r=me, but it looks like it needs to be rebased so I listed a couple of drive-by changes you might make.

> Source/WebCore/Modules/mediastream/MediaStream.cpp:137
> +void MediaStream::cloneMediaStreamTrackVector(Vector<RefPtr<MediaStreamTrack>>& destination, const Vector<RefPtr<MediaStreamTrack>>& origin)

Nit: while you are here, can you change "origin" to "source"?

> Source/WebCore/Modules/mediastream/MediaStream.cpp:219
> +        for (Vector<RefPtr<MediaStreamTrack>>::iterator iter = m_audioTracks.begin(); iter != m_audioTracks.end(); ++iter) {

Nit: while you are here, can you fix this to use "auto"?

> Source/WebCore/Modules/mediastream/MediaStream.cpp:226
> +    for (Vector<RefPtr<MediaStreamTrack>>::iterator iter = m_videoTracks.begin(); iter != m_videoTracks.end(); ++iter) {

Ditto.

> Source/WebCore/Modules/mediastream/MediaStream.cpp:236
> +    for (Vector<RefPtr<MediaStreamTrack>>::iterator iter = m_audioTracks.begin(); iter != m_audioTracks.end(); ++iter) {

Ditto.

> Source/WebCore/Modules/mediastream/MediaStream.cpp:241
> +    for (Vector<RefPtr<MediaStreamTrack>>::iterator iter = m_videoTracks.begin(); iter != m_videoTracks.end(); ++iter) {

Ditto.

> Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:169
> +    for (Vector<RefPtr<MediaStreamTrack>>::iterator iter = tracks.begin(); iter != tracks.end(); ++iter)

Ditto.

> Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:173
> +    for (Vector<RefPtr<MediaStreamTrack>>::iterator iter = tracks.begin(); iter != tracks.end(); ++iter)

Ditto.

[Thiago de Barros Lacerda]

(In reply to comment #2)
> (From update of attachment 215781 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=215781&action=review
> 
> This looks good, thanks for doing it! 
> 
> r=me, but it looks like it needs to be rebased so I listed a couple of drive-by changes you might make.
> 
> > Source/WebCore/Modules/mediastream/MediaStream.cpp:137
> > +void MediaStream::cloneMediaStreamTrackVector(Vector<RefPtr<MediaStreamTrack>>& destination, const Vector<RefPtr<MediaStreamTrack>>& origin)
> 
> Nit: while you are here, can you change "origin" to "source"?
> 
> > Source/WebCore/Modules/mediastream/MediaStream.cpp:219
> > +        for (Vector<RefPtr<MediaStreamTrack>>::iterator iter = m_audioTracks.begin(); iter != m_audioTracks.end(); ++iter) {
> 
> Nit: while you are here, can you fix this to use "auto"?
> 
> > Source/WebCore/Modules/mediastream/MediaStream.cpp:226
> > +    for (Vector<RefPtr<MediaStreamTrack>>::iterator iter = m_videoTracks.begin(); iter != m_videoTracks.end(); ++iter) {
> 
> Ditto.
> 
> > Source/WebCore/Modules/mediastream/MediaStream.cpp:236
> > +    for (Vector<RefPtr<MediaStreamTrack>>::iterator iter = m_audioTracks.begin(); iter != m_audioTracks.end(); ++iter) {
> 
> Ditto.
> 
> > Source/WebCore/Modules/mediastream/MediaStream.cpp:241
> > +    for (Vector<RefPtr<MediaStreamTrack>>::iterator iter = m_videoTracks.begin(); iter != m_videoTracks.end(); ++iter) {
> 
> Ditto.
> 
> > Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:169
> > +    for (Vector<RefPtr<MediaStreamTrack>>::iterator iter = tracks.begin(); iter != tracks.end(); ++iter)
> 
> Ditto.
> 
> > Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:173
> > +    for (Vector<RefPtr<MediaStreamTrack>>::iterator iter = tracks.begin(); iter != tracks.end(); ++iter)
> 
> Ditto.

OK for all

[Thiago de Barros Lacerda]

Created attachment 215791 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 215791 [details]
Patch

Clearing flags on attachment: 215791

Committed r158480: <http://trac.webkit.org/changeset/158480>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.