Bug 123645 - CSSAspectRatioValue construction helper should return PassRef.
Summary: CSSAspectRatioValue construction helper should return PassRef.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-01 15:58 PDT by Andreas Kling
Modified: 2013-11-01 18:01 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.64 KB, patch)
2013-11-01 15:58 PDT, Andreas Kling
darin: review+
Details | Formatted Diff | Diff
Patch for landing (1.37 KB, patch)
2013-11-01 17:23 PDT, Andreas Kling
kling: commit-queue+
Details | Formatted Diff | Diff
Patch for landing (1.37 KB, patch)
2013-11-01 17:29 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-11-01 15:58:06 PDT
CSSAspectRatioValue construction helper should return PassRef.
Comment 1 Andreas Kling 2013-11-01 15:58:47 PDT
Created attachment 215773 [details]
Patch
Comment 2 Darin Adler 2013-11-01 16:14:21 PDT
Comment on attachment 215773 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215773&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

OOPS!?

No file list?

> Source/WebCore/css/CSSAspectRatioValue.h:52
> +    explicit CSSAspectRatioValue(float numeratorValue, float denominatorValue)

Two arguments -- no need for explicit, which only affects things with one argument.
Comment 3 Andreas Kling 2013-11-01 16:15:54 PDT
(In reply to comment #2)
> (From update of attachment 215773 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=215773&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        No new tests (OOPS!).
> 
> OOPS!?
> 
> No file list?
> 
> > Source/WebCore/css/CSSAspectRatioValue.h:52
> > +    explicit CSSAspectRatioValue(float numeratorValue, float denominatorValue)
> 
> Two arguments -- no need for explicit, which only affects things with one argument.

Urgh. Hardcore rush job. :|
Comment 4 Andreas Kling 2013-11-01 17:23:16 PDT
Created attachment 215783 [details]
Patch for landing
Comment 5 Andreas Kling 2013-11-01 17:29:45 PDT
Created attachment 215784 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2013-11-01 18:01:33 PDT
Comment on attachment 215784 [details]
Patch for landing

Clearing flags on attachment: 215784

Committed r158469: <http://trac.webkit.org/changeset/158469>
Comment 7 WebKit Commit Bot 2013-11-01 18:01:36 PDT
All reviewed patches have been landed.  Closing bug.