CSSAspectRatioValue construction helper should return PassRef.
Created attachment 215773 [details] Patch
Comment on attachment 215773 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215773&action=review > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). OOPS!? No file list? > Source/WebCore/css/CSSAspectRatioValue.h:52 > + explicit CSSAspectRatioValue(float numeratorValue, float denominatorValue) Two arguments -- no need for explicit, which only affects things with one argument.
(In reply to comment #2) > (From update of attachment 215773 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=215773&action=review > > > Source/WebCore/ChangeLog:8 > > + No new tests (OOPS!). > > OOPS!? > > No file list? > > > Source/WebCore/css/CSSAspectRatioValue.h:52 > > + explicit CSSAspectRatioValue(float numeratorValue, float denominatorValue) > > Two arguments -- no need for explicit, which only affects things with one argument. Urgh. Hardcore rush job. :|
Created attachment 215783 [details] Patch for landing
Created attachment 215784 [details] Patch for landing
Comment on attachment 215784 [details] Patch for landing Clearing flags on attachment: 215784 Committed r158469: <http://trac.webkit.org/changeset/158469>
All reviewed patches have been landed. Closing bug.