Bug 123635 – Move CF/Mac WTF String implementations down into WTF

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Template Framework

[Joseph Pecoraro]

Some WTF String functions were implemented in WebCore even though they were defined in WTF headers.

I want to move the implementations down into WTF, and potentially use them in JavaScriptCore.

[Joseph Pecoraro]

Created attachment 215760 [details]
[PATCH] Proposed Fix (for bots)

I attempted to update Windows projects, I don't know if it will succeed.

[WebKit Commit Bot]

Attachment 215760 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/WTF.vcxproj/WTF.vcxproj', u'Source/WTF/WTF.vcxproj/WTF.vcxproj.filters', u'Source/WTF/WTF.xcodeproj/project.pbxproj', u'Source/WTF/wtf/text/AtomicString.h', u'Source/WTF/wtf/text/StringImpl.h', u'Source/WTF/wtf/text/WTFString.h', u'Source/WTF/wtf/text/cf/AtomicStringCF.cpp', u'Source/WTF/wtf/text/cf/StringCF.cpp', u'Source/WTF/wtf/text/cf/StringImplCF.cpp', u'Source/WTF/wtf/text/mac/StringImplMac.mm', u'Source/WTF/wtf/text/mac/StringMac.mm', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/platform/text/cf/AtomicStringCF.cpp', u'Source/WebCore/platform/text/cf/StringCF.cpp', u'Source/WebCore/platform/text/cf/StringImplCF.cpp', u'Source/WebCore/platform/text/mac/StringImplMac.mm', u'Source/WebCore/platform/text/mac/StringMac.mm']" exit_code: 1
Source/WTF/wtf/text/WTFString.h:412:  Use 0 or null instead of NULL (even in *comments*).  [readability/null] [4]
Source/WTF/wtf/text/cf/StringCF.cpp:37:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WTF/wtf/text/cf/StringImplCF.cpp:49:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 3 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Joseph Pecoraro]

Heh, unfortunately the bot I care about couldn't apply the patch. That is probably a bad sign.

[Joseph Pecoraro]

Created attachment 215785 [details]
[PATCH] For Windows Bots

[WebKit Commit Bot]

Attachment 215785 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/WTF.vcxproj/WTF.vcxproj', u'Source/WTF/WTF.vcxproj/WTF.vcxproj.filters', u'Source/WTF/WTF.xcodeproj/project.pbxproj', u'Source/WTF/wtf/text/AtomicString.h', u'Source/WTF/wtf/text/StringImpl.h', u'Source/WTF/wtf/text/WTFString.h', u'Source/WTF/wtf/text/cf/AtomicStringCF.cpp', u'Source/WTF/wtf/text/cf/StringCF.cpp', u'Source/WTF/wtf/text/cf/StringImplCF.cpp', u'Source/WTF/wtf/text/mac/StringImplMac.mm', u'Source/WTF/wtf/text/mac/StringMac.mm', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/platform/text/cf/AtomicStringCF.cpp', u'Source/WebCore/platform/text/cf/StringCF.cpp', u'Source/WebCore/platform/text/cf/StringImplCF.cpp', u'Source/WebCore/platform/text/mac/StringImplMac.mm', u'Source/WebCore/platform/text/mac/StringMac.mm']" exit_code: 1
Source/WTF/wtf/text/WTFString.h:412:  Use 0 or null instead of NULL (even in *comments*).  [readability/null] [4]
Source/WTF/wtf/text/cf/StringCF.cpp:37:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WTF/wtf/text/cf/StringImplCF.cpp:49:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 3 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Joseph Pecoraro]

Comment on attachment 215785 [details]
[PATCH] For Windows Bots

Going to CQ+ and check bots. I got a sanity check from Windows developers.

[WebKit Commit Bot]

Comment on attachment 215760 [details]
[PATCH] Proposed Fix (for bots)

Clearing flags on attachment: 215760

Committed r158471: <http://trac.webkit.org/changeset/158471>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Joseph Pecoraro]

Broke windows.

Attempt at a build fix with:
<http://trac.webkit.org/changeset/158475>

[Joseph Pecoraro]

And another, I missed a few includes:
<http://trac.webkit.org/changeset/158479>

[Joseph Pecoraro]

Bots look good now!