Bug 123631 - Begin work on encoding argument types
Summary: Begin work on encoding argument types
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-01 13:38 PDT by Anders Carlsson
Modified: 2013-11-01 13:58 PDT (History)
0 users

See Also:

Attachments
Patch (7.19 KB, patch)
2013-11-01 13:42 PDT, Anders Carlsson 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-11-01 13:38:56 PDT 
Begin work on encoding argument types
Comment 1 Anders Carlsson 2013-11-01 13:42:33 PDT 
Created attachment 215754 [details]
Patch
Comment 2 mitz 2013-11-01 13:47:57 PDT 
Comment on attachment 215754 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215754&action=review

> Source/WebKit2/ChangeLog:13
> +        Add new helper function that encodes an object and returns the dictionary.

s/function/method/

> Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectCoder.mm:98
> +        // Should always self and _cmd.

Should always what self and _cmd?
Comment 3 Anders Carlsson 2013-11-01 13:58:24 PDT 
Committed r158452: <http://trac.webkit.org/changeset/158452>