Bug 123626 - [iOS] Make some headers Private
Summary: [iOS] Make some headers Private
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-01 11:31 PDT by Andy Estes
Modified: 2013-11-01 14:05 PDT (History)
1 user (show)

See Also:

Attachments
[iOS] Make some headers Private (13.21 KB, patch)
2013-11-01 11:32 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
[iOS] Make some headers Private (15.03 KB, patch)
2013-11-01 13:55 PDT, Andy Estes 		kling: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2013-11-01 11:31:33 PDT 
[iOS] Make some headers Private
Comment 1 Andy Estes 2013-11-01 11:32:52 PDT 
Created attachment 215745 [details]
[iOS] Make some headers Private
Comment 2 Andy Estes 2013-11-01 11:36:23 PDT 
Committed r158443: <http://trac.webkit.org/changeset/158443>
Comment 3 Andy Estes 2013-11-01 12:11:04 PDT 
Reverted in https://trac.webkit.org/r158446 since this broke the build.
Comment 4 Andy Estes 2013-11-01 13:55:50 PDT 
Created attachment 215757 [details]
[iOS] Make some headers Private
Comment 5 Andreas Kling 2013-11-01 14:00:07 PDT 
Comment on attachment 215757 [details]
[iOS] Make some headers Private

rs=me
Comment 6 Andreas Kling 2013-11-01 14:01:05 PDT 
Comment on attachment 215757 [details]
[iOS] Make some headers Private

View in context: https://bugs.webkit.org/attachment.cgi?id=215757&action=review

> Source/WebKit/mac/Configurations/WebKit.xcconfig:30
> +EXCLUDED_SOURCE_FILE_NAMES_macosx = *IOS.mm WebKit.iOS.exp MemoryMeasure.h WebGeolocationCoreLocationProvider.h WebGeolocationProviderIOS.h WebNSStringDrawing.h WebNSStringExtrasIOS.h WebNSStringExtrasIPhone.h WebUIKitSupport.h WebCaretChangeListener.h WebFixedPositionContent.h WebFrameIOS.h WebFrameIPhone.h WebGeolocationPrivate.h WebMIMETypeRegistry.h WebSelectionRect.h WebVisiblePosition.h WebUIKitDelegate.h WebPDFViewIOS.h WebPDFViewIPhone.h WebPDFViewPlaceholder.h;

This doesn't feel very future-proof.
Comment 7 Andreas Kling 2013-11-01 14:01:06 PDT 
Comment on attachment 215757 [details]
[iOS] Make some headers Private

View in context: https://bugs.webkit.org/attachment.cgi?id=215757&action=review

> Source/WebKit/mac/Configurations/WebKit.xcconfig:30
> +EXCLUDED_SOURCE_FILE_NAMES_macosx = *IOS.mm WebKit.iOS.exp MemoryMeasure.h WebGeolocationCoreLocationProvider.h WebGeolocationProviderIOS.h WebNSStringDrawing.h WebNSStringExtrasIOS.h WebNSStringExtrasIPhone.h WebUIKitSupport.h WebCaretChangeListener.h WebFixedPositionContent.h WebFrameIOS.h WebFrameIPhone.h WebGeolocationPrivate.h WebMIMETypeRegistry.h WebSelectionRect.h WebVisiblePosition.h WebUIKitDelegate.h WebPDFViewIOS.h WebPDFViewIPhone.h WebPDFViewPlaceholder.h;

This doesn't feel very future-proof.
Comment 8 Andy Estes 2013-11-01 14:05:25 PDT 
Committed r158454: <http://trac.webkit.org/changeset/158454>