Bug 123622 - [GTK] Fix build on non-linux platforms
Summary: [GTK] Fix build on non-linux platforms
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-01 10:25 PDT by Emilio Pozuelo Monfort
Modified: 2013-11-01 11:46 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.19 KB, patch)
2013-11-01 10:27 PDT, Emilio Pozuelo Monfort
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Emilio Pozuelo Monfort 2013-11-01 10:25:41 PDT
webkit 2.2.1 has started to fail to build on debian/kfreebsd and debian/hurd because of a missing socket.h include. I guess it was working before because of an indirect include, as ProcessLauncherGtk.cpp hasn't changed in this regard.

The proposed fix drops the prctl include which is unnecessary and includes socket.h on every UNIX platform (as that's a file mandated by POSIX). It fixes the build in both mentioned platforms in Debian, and probably benefits other UNIX-like platforms.
Comment 1 Emilio Pozuelo Monfort 2013-11-01 10:27:41 PDT
Created attachment 215739 [details]
Patch
Comment 2 WebKit Commit Bot 2013-11-01 11:46:30 PDT
Comment on attachment 215739 [details]
Patch

Clearing flags on attachment: 215739

Committed r158444: <http://trac.webkit.org/changeset/158444>
Comment 3 WebKit Commit Bot 2013-11-01 11:46:31 PDT
All reviewed patches have been landed.  Closing bug.