Bug 123621 - [PluginProxy] Add a setting to disable video plugin proxy support in HTMLMediaElement.
Summary: [PluginProxy] Add a setting to disable video plugin proxy support in HTMLMedi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-01 10:25 PDT by Jer Noble
Modified: 2013-11-04 14:51 PST (History)
12 users (show)

See Also:

Attachments
Patch (49.09 KB, patch)
2013-11-01 10:34 PDT, Jer Noble 		eric.carlson: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 (513.55 KB, application/zip)
2013-11-01 11:49 PDT, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion (614.79 KB, application/zip)
2013-11-01 13:05 PDT, Build Bot 		no flags Details
Patch for committing (49.10 KB, patch)
2013-11-01 14:04 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (568.75 KB, application/zip)
2013-11-01 15:15 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2013-11-01 10:25:40 PDT 
[PluginProxy] Add a setting to disable video plugin proxy support in HTMLMediaElement.
Comment 1 Jer Noble 2013-11-01 10:34:01 PDT 
Created attachment 215740 [details]
Patch
Comment 2 WebKit Commit Bot 2013-11-01 10:35:29 PDT 
Attachment 215740 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Platform.h', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/HTMLMediaElement.h', u'Source/WebCore/html/HTMLVideoElement.cpp', u'Source/WebCore/html/HTMLVideoElement.h', u'Source/WebCore/page/Settings.cpp', u'Source/WebCore/page/Settings.h', u'Source/WebCore/platform/graphics/MediaPlayer.cpp', u'Source/WebCore/platform/graphics/MediaPlayerPrivate.h', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm', u'Source/WebCore/platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h', u'Source/WebCore/platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h', u'Source/WebKit/mac/WebView/WebPreferences.mm', u'Source/WebKit/mac/WebView/WebPreferencesPrivate.h', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/WebPreferencesStore.h', u'Source/WebKit2/UIProcess/API/C/WKPreferences.cpp', u'Source/WebKit2/UIProcess/API/C/WKPreferences.h', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp']" exit_code: 1
Source/WebCore/html/HTMLMediaElement.cpp:857:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2013-11-01 11:49:58 PDT 
Comment on attachment 215740 [details]
Patch

Attachment 215740 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/19668052

New failing tests:
fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html
media/video-canvas-drawing-output.html
webgl/1.0.1/conformance/textures/texture-npot-video.html
webgl/1.0.1/conformance/textures/tex-image-and-sub-image-2d-with-video.html
webgl/1.0.2/conformance/extensions/oes-texture-float-with-video.html
webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba5551.html
webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-video-rgb565.html
webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-video.html
webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba4444.html
webgl/1.0.2/conformance/textures/texture-npot-video.html
Comment 4 Build Bot 2013-11-01 11:49:59 PDT 
Created attachment 215746 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 5 Build Bot 2013-11-01 13:05:25 PDT 
Comment on attachment 215740 [details]
Patch

Attachment 215740 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/19638072

New failing tests:
fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html
media/video-canvas-drawing-output.html
webgl/1.0.1/conformance/textures/texture-npot-video.html
webgl/1.0.1/conformance/textures/tex-image-and-sub-image-2d-with-video.html
webgl/1.0.2/conformance/extensions/oes-texture-float-with-video.html
webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba5551.html
webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-video-rgb565.html
webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-video.html
webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba4444.html
webgl/1.0.2/conformance/textures/texture-npot-video.html
Comment 6 Build Bot 2013-11-01 13:05:28 PDT 
Created attachment 215751 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 7 Jer Noble 2013-11-01 14:04:06 PDT 
Created attachment 215758 [details]
Patch for committing

Explicitly set the colorspace when creating the video's image.
Comment 8 WebKit Commit Bot 2013-11-01 14:12:40 PDT 
Attachment 215758 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Platform.h', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/HTMLMediaElement.h', u'Source/WebCore/html/HTMLVideoElement.cpp', u'Source/WebCore/html/HTMLVideoElement.h', u'Source/WebCore/page/Settings.cpp', u'Source/WebCore/page/Settings.h', u'Source/WebCore/platform/graphics/MediaPlayer.cpp', u'Source/WebCore/platform/graphics/MediaPlayerPrivate.h', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm', u'Source/WebCore/platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h', u'Source/WebCore/platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h', u'Source/WebKit/mac/WebView/WebPreferences.mm', u'Source/WebKit/mac/WebView/WebPreferencesPrivate.h', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/WebPreferencesStore.h', u'Source/WebKit2/UIProcess/API/C/WKPreferences.cpp', u'Source/WebKit2/UIProcess/API/C/WKPreferences.h', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp']" exit_code: 1
Source/WebCore/html/HTMLMediaElement.cpp:857:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Build Bot 2013-11-01 15:15:12 PDT 
Comment on attachment 215740 [details]
Patch

Attachment 215740 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/19668085

New failing tests:
fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html
media/video-canvas-drawing-output.html
webgl/1.0.1/conformance/textures/texture-npot-video.html
webgl/1.0.1/conformance/textures/tex-image-and-sub-image-2d-with-video.html
webgl/1.0.2/conformance/extensions/oes-texture-float-with-video.html
webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba5551.html
webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-video-rgb565.html
webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-video.html
webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba4444.html
webgl/1.0.2/conformance/textures/texture-npot-video.html
Comment 10 Build Bot 2013-11-01 15:15:14 PDT 
Created attachment 215767 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 11 Jer Noble 2013-11-04 14:51:38 PST 
Committed r158599: <http://trac.webkit.org/changeset/158599>