Bug 123620 - Explicitly initialize RefCounted base class in MediaStreamTrack's constructors
Summary: Explicitly initialize RefCounted base class in MediaStreamTrack's constructors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nick Diego Yamane (diegoyam)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-01 10:23 PDT by Nick Diego Yamane (diegoyam)
Modified: 2013-11-01 11:28 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.85 KB, patch)
2013-11-01 10:26 PDT, Nick Diego Yamane (diegoyam) 		no flags Details | Formatted Diff | Diff
Patch (1.85 KB, patch)
2013-11-01 10:46 PDT, Nick Diego Yamane (diegoyam) 		no flags Details | Formatted Diff | Diff
Patch (1.86 KB, patch)
2013-11-01 10:53 PDT, Nick Diego Yamane (diegoyam) 		no flags Details | Formatted Diff | Diff
Patch (1.51 KB, patch)
2013-11-01 11:18 PDT, Nick Diego Yamane (diegoyam) 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Diego Yamane (diegoyam) 2013-11-01 10:23:49 PDT 
Explicitly initialize RefCounted base class in MediaStreamTrack's constructors
Comment 1 Nick Diego Yamane (diegoyam) 2013-11-01 10:26:38 PDT 
Created attachment 215737 [details]
Patch
Comment 2 Andreas Kling 2013-11-01 10:43:48 PDT 
Comment on attachment 215737 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215737&action=review

r=me

> Source/WebCore/ChangeLog:8
> +        No new needed.

No new what needed?
Comment 3 Nick Diego Yamane (diegoyam) 2013-11-01 10:46:56 PDT 
Created attachment 215741 [details]
Patch
Comment 4 Nick Diego Yamane (diegoyam) 2013-11-01 10:53:07 PDT 
Created attachment 215742 [details]
Patch
Comment 5 WebKit Commit Bot 2013-11-01 11:02:08 PDT 
Comment on attachment 215742 [details]
Patch

Rejecting attachment 215742 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 215742, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
cwd: /Volumes/Data/EWS/WebKit

Parsed 2 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp
Hunk #2 FAILED at 67.
1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Andreas Kling']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/19688044
Comment 6 Nick Diego Yamane (diegoyam) 2013-11-01 11:18:32 PDT 
Created attachment 215743 [details]
Patch
Comment 7 WebKit Commit Bot 2013-11-01 11:28:15 PDT 
Comment on attachment 215743 [details]
Patch

Clearing flags on attachment: 215743

Committed r158442: <http://trac.webkit.org/changeset/158442>
Comment 8 WebKit Commit Bot 2013-11-01 11:28:17 PDT 
All reviewed patches have been landed.  Closing bug.