Bug 123619 - Move duplicate code in TrackPrivate classes to a common base class
Summary: Move duplicate code in TrackPrivate classes to a common base class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brendan Long
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-01 10:09 PDT by Brendan Long
Modified: 2013-11-04 17:35 PST (History)
11 users (show)

See Also:

Attachments
Patch (29.54 KB, patch)
2013-11-01 10:19 PDT, Brendan Long 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brendan Long 2013-11-01 10:09:54 PDT 
Move duplicate code in TrackPrivate classes to a common base class
Comment 1 Brendan Long 2013-11-01 10:19:40 PDT 
Created attachment 215735 [details]
Patch

Question: Was it correct to move the `WTF_MAKE_NONCOPYABLE(VideoTrackPrivate); WTF_MAKE_FAST_ALLOCATED;` to TrackPrivateBase, or does that need to stay in the derived classes?
Comment 2 Darin Adler 2013-11-01 11:34:25 PDT 
(In reply to comment #1)
> Question: Was it correct to move the `WTF_MAKE_NONCOPYABLE(VideoTrackPrivate); WTF_MAKE_FAST_ALLOCATED;` to TrackPrivateBase, or does that need to stay in the derived classes?

WTF_MAKE_NONCOPYABLE can just be in the base class. I don’t know the answer about WTF_MAKE_FAST_ALLOCATED.
Comment 3 Philippe Normand 2013-11-04 06:26:41 PST 
The patch looks good to me provided the question about WTF_MAKE_FAST_ALLOCATED gets an answer :)

Looking at the definition of the macro in Source/WTF/wtf/FastMalloc.h it seems to me that it can be used in the base class and that would be it. It'd be better to confirm that with someone more familiar with that though.
Comment 4 WebKit Commit Bot 2013-11-04 17:35:35 PST 
Comment on attachment 215735 [details]
Patch

Clearing flags on attachment: 215735

Committed r158626: <http://trac.webkit.org/changeset/158626>
Comment 5 WebKit Commit Bot 2013-11-04 17:35:37 PST 
All reviewed patches have been landed.  Closing bug.