Bug 123609 - [EFL][WK1] Rendering is broken when scrolled ewk_view_single repeatedly
Summary: [EFL][WK1] Rendering is broken when scrolled ewk_view_single repeatedly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-31 21:13 PDT by Ryuan Choi
Modified: 2013-11-01 00:13 PDT (History)
5 users (show)

See Also:

Attachments
screenshot (441.15 KB, image/png)
2013-10-31 21:13 PDT, Ryuan Choi 		no flags Details
Patch (2.74 KB, patch)
2013-10-31 21:45 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Patch (2.72 KB, patch)
2013-10-31 23:32 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2013-10-31 21:13:59 PDT 
Created attachment 215714 [details]
screenshot

When scrolled wek_view_single fast and repeatedly,
Rendered results are sometimes broken.
Comment 1 Ryuan Choi 2013-10-31 21:45:24 PDT 
Created attachment 215715 [details]
Patch
Comment 2 Gyuyoung Kim 2013-10-31 22:29:03 PDT 
Comment on attachment 215715 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215715&action=review

> Source/WebKit/efl/ewk/ewk_view_single.cpp:200
> +    WebCore::IntRect rectToScroll = WebCore::IntRect(0, 0, imageWidth, imageHeight);

Isn't below more simple ?

WebCore::IntRect rectToScroll(0, 0, imageWidth, imageHeight);
Comment 3 Ryuan Choi 2013-10-31 23:32:03 PDT 
Created attachment 215719 [details]
Patch
Comment 4 Ryuan Choi 2013-10-31 23:32:55 PDT 
(In reply to comment #2)
> (From update of attachment 215715 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=215715&action=review
> 
> > Source/WebKit/efl/ewk/ewk_view_single.cpp:200
> > +    WebCore::IntRect rectToScroll = WebCore::IntRect(0, 0, imageWidth, imageHeight);
> 
> Isn't below more simple ?
> 
> WebCore::IntRect rectToScroll(0, 0, imageWidth, imageHeight);

Absolutely right.

Fixed.
Comment 5 WebKit Commit Bot 2013-11-01 00:13:45 PDT 
Comment on attachment 215719 [details]
Patch

Clearing flags on attachment: 215719

Committed r158426: <http://trac.webkit.org/changeset/158426>
Comment 6 WebKit Commit Bot 2013-11-01 00:13:48 PDT 
All reviewed patches have been landed.  Closing bug.