Bug 123599 - std::function prefers nullptr
Summary: std::function prefers nullptr
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 8
: P2 Trivial
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-31 17:20 PDT by Alex Christensen
Modified: 2013-10-31 17:59 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.08 KB, patch)
2013-10-31 17:22 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2013-10-31 17:20:02 PDT 
Hooray for C++11!  In order to get WebKit to compile with VS2012, we're going to have to be careful with our std::function usage.  Setting it to 0 causes all kinds of nasty template compile problems, but setting it to nullptr makes everybody happy.
Comment 1 Brent Fulgham 2013-10-31 17:21:36 PDT 
These should probably be safe to apply as we go, since nullptr is probably the "right" thing to be using anyway.
Comment 2 Alex Christensen 2013-10-31 17:22:16 PDT 
Created attachment 215695 [details]
Patch
Comment 3 Brent Fulgham 2013-10-31 17:27:37 PDT 
Comment on attachment 215695 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2013-10-31 17:59:30 PDT 
Comment on attachment 215695 [details]
Patch

Clearing flags on attachment: 215695

Committed r158414: <http://trac.webkit.org/changeset/158414>
Comment 5 WebKit Commit Bot 2013-10-31 17:59:31 PDT 
All reviewed patches have been landed.  Closing bug.