Bug 123589 - Web Inspector: Breakpoints in auto-formatted JavaScript editors are not working
Summary: Web Inspector: Breakpoints in auto-formatted JavaScript editors are not working
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-10-31 13:31 PDT by Joseph Pecoraro
Modified: 2013-10-31 16:10 PDT (History)
5 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (2.99 KB, patch)
2013-10-31 15:38 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2013-10-31 13:31:21 PDT
Looks like the recent change to allow editing pretty-printed resources has an unintended side effect here.
Comment 1 Joseph Pecoraro 2013-10-31 13:32:43 PDT
Updated the title to be clearer. Breakpoints in auto-formatted JS resources are not working, because the formatterSourceMap is getting cleared. The file appears as if it is not pretty-printed, even though it is.
Comment 2 Radar WebKit Bug Importer 2013-10-31 13:33:07 PDT
<rdar://problem/15365257>
Comment 3 Joseph Pecoraro 2013-10-31 15:38:01 PDT
Created attachment 215683 [details]
[PATCH] Proposed Fix
Comment 4 Joseph Pecoraro 2013-10-31 15:40:42 PDT
STEPS TO REPRODUCE:
1. Inspect <http://bogojoker.com/shell/>
2. Select easySlider.min.js in resource sidebar
  => file should auto format, pretty print button should be blue, breakpoints should work past line 4.
Comment 5 WebKit Commit Bot 2013-10-31 16:10:22 PDT
Comment on attachment 215683 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 215683

Committed r158404: <http://trac.webkit.org/changeset/158404>
Comment 6 WebKit Commit Bot 2013-10-31 16:10:24 PDT
All reviewed patches have been landed.  Closing bug.