Bug 123587 - Enable WebCrypto on Mac
Summary: Enable WebCrypto on Mac
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
Depends on:
Blocks: 122679
  Show dependency treegraph
Reported: 2013-10-31 13:18 PDT by Alexey Proskuryakov
Modified: 2013-10-31 14:48 PDT (History)
6 users (show)

See Also:

proposed patch (72.04 KB, patch)
2013-10-31 13:24 PDT, Alexey Proskuryakov
andersca: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
patch for landing (72.46 KB, patch)
2013-10-31 14:17 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-10-31 13:18:08 PDT
There is only one algorithm yet, but it builds and it has tests.
Comment 1 Alexey Proskuryakov 2013-10-31 13:24:31 PDT
Created attachment 215670 [details]
proposed patch
Comment 2 WebKit Commit Bot 2013-10-31 14:12:03 PDT
Comment on attachment 215670 [details]
proposed patch

Rejecting attachment 215670 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ringEPNS_9ExecStateERKN3WTF6StringE in JSCryptoAlgorithmBuilder.o
  "__ZNK3JSC7JSValue6asCellEv", referenced from:
      __ZN3JSC8jsStringEPNS_9ExecStateERKN3WTF6StringE in JSCryptoAlgorithmBuilder.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)


The following build commands failed:
	Ld /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCore.framework/Versions/A/WebCore normal x86_64
(1 failure)

Full output: http://webkit-queues.appspot.com/results/18788045
Comment 3 Alexey Proskuryakov 2013-10-31 14:17:18 PDT
Created attachment 215677 [details]
patch for landing

With a release build fix.
Comment 4 WebKit Commit Bot 2013-10-31 14:48:14 PDT
Comment on attachment 215677 [details]
patch for landing

Clearing flags on attachment: 215677

Committed r158396: <http://trac.webkit.org/changeset/158396>
Comment 5 WebKit Commit Bot 2013-10-31 14:48:16 PDT
All reviewed patches have been landed.  Closing bug.