Bug 123574 – Remove CachedTranscendentalFunction because caching math functions is an ugly idea

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

Patch forthcoming.

[Filip Pizlo]

Created attachment 215656 [details]
the patch

[WebKit Commit Bot]

Attachment 215656 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h', u'Source/JavaScriptCore/dfg/DFGBackwardsPropagationPhase.cpp', u'Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp', u'Source/JavaScriptCore/dfg/DFGCSEPhase.cpp', u'Source/JavaScriptCore/dfg/DFGClobberize.h', u'Source/JavaScriptCore/dfg/DFGFixupPhase.cpp', u'Source/JavaScriptCore/dfg/DFGNodeType.h', u'Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp', u'Source/JavaScriptCore/dfg/DFGSafeToExecute.h', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp', u'Source/JavaScriptCore/jit/JITOperations.h', u'Source/JavaScriptCore/runtime/CachedTranscendentalFunction.h', u'Source/JavaScriptCore/runtime/DateInstanceCache.h', u'Source/JavaScriptCore/runtime/Intrinsic.h', u'Source/JavaScriptCore/runtime/MathObject.cpp', u'Source/JavaScriptCore/runtime/VM.h']" exit_code: 1
Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:566:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Mark Hahnenberg]

Comment on attachment 215656 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215656&action=review

r=me

> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:570
> +            setConstant(node, jsNumber(sin(child.asNumber())));

Is this supposed to be cos?

> Source/JavaScriptCore/runtime/DateInstanceCache.h:29
> +#include "JSCJSValue.h"

Is this necessary?

[Michael Saboff]

Comment on attachment 215656 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215656&action=review

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1485
>          if (argumentCountIncludingThis == 1) { // Math.sqrt()

Remove/change the Math.sqrt() comment

[Filip Pizlo]

(In reply to comment #3)
> (From update of attachment 215656 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=215656&action=review
> 
> r=me
> 
> > Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:570
> > +            setConstant(node, jsNumber(sin(child.asNumber())));
> 
> Is this supposed to be cos?

Heh.  Good point.  I added a test.

> 
> > Source/JavaScriptCore/runtime/DateInstanceCache.h:29
> > +#include "JSCJSValue.h"
> 
> Is this necessary?

Yup!

[Filip Pizlo]

(In reply to comment #2)
> Attachment 215656 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h', u'Source/JavaScriptCore/dfg/DFGBackwardsPropagationPhase.cpp', u'Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp', u'Source/JavaScriptCore/dfg/DFGCSEPhase.cpp', u'Source/JavaScriptCore/dfg/DFGClobberize.h', u'Source/JavaScriptCore/dfg/DFGFixupPhase.cpp', u'Source/JavaScriptCore/dfg/DFGNodeType.h', u'Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp', u'Source/JavaScriptCore/dfg/DFGSafeToExecute.h', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp', u'Source/JavaScriptCore/jit/JITOperations.h', u'Source/JavaScriptCore/runtime/CachedTranscendentalFunction.h', u'Source/JavaScriptCore/runtime/DateInstanceCache.h', u'Source/JavaScriptCore/runtime/Intrinsic.h', u'Source/JavaScriptCore/runtime/MathObject.cpp', u'Source/JavaScriptCore/runtime/VM.h']" exit_code: 1
> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:566:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]

Fixed.

> Total errors found: 1 in 16 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

[Filip Pizlo]

(In reply to comment #4)
> (From update of attachment 215656 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=215656&action=review
> 
> > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1485
> >          if (argumentCountIncludingThis == 1) { // Math.sqrt()
> 
> Remove/change the Math.sqrt() comment

Fixed.

[Filip Pizlo]

Landed in http://trac.webkit.org/changeset/158384 and http://trac.webkit.org/changeset/158385