RESOLVED INVALID 123564
[WINCE] Focus events do not work 
https://bugs.webkit.org/show_bug.cgi?id=123564
Summary [WINCE] Focus events do not work
Zhuang Zhigang
Reported 2013-10-31 02:21:14 PDT
WinCE port does not process focus events.
Attachments
a patch for focus (2.05 KB, patch)
2013-10-31 02:48 PDT, Zhuang Zhigang 		no flags
DetailsFormatted DiffDiff
update (2.05 KB, patch)
2013-10-31 18:09 PDT, Zhuang Zhigang 		no flags
DetailsFormatted DiffDiff
A new patch (2.27 KB, patch)
2013-11-01 01:46 PDT, Zhuang Zhigang 		paroga: review-
DetailsFormatted DiffDiff
updated patch (2.06 KB, patch)
2013-11-03 22:05 PST, Zhuang Zhigang 		bfulgham: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Zhuang Zhigang
Comment 1 2013-10-31 02:48:46 PDT
Created attachment 215640 [details] a patch for focus add the process for WM_SETFOCUS and WM_KILLFOCUS in WebView::wndProc.
Zhuang Zhigang
Comment 2 2013-10-31 18:09:07 PDT
Created attachment 215708 [details] update
Patrick R. Gansterer
Comment 3 2013-11-01 01:08:30 PDT
Comment on attachment 215708 [details] update View in context: https://bugs.webkit.org/attachment.cgi?id=215708&action=review > Source/WebKit/wince/WebView.cpp:453 > + focusController = m_webpage->page()->focusController(); Where is focusController declared?
Zhuang Zhigang
Comment 4 2013-11-01 01:38:32 PDT
(In reply to comment #3) > (From update of attachment 215708 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=215708&action=review > > > Source/WebKit/wince/WebView.cpp:453 > > + focusController = m_webpage->page()->focusController(); > > Where is focusController declared? Sorry, I made a mistake. I will add the declaration of focusController and upload a new patch.
Zhuang Zhigang
Comment 5 2013-11-01 01:46:13 PDT
Created attachment 215724 [details] A new patch Add declaration of FocusController. Please check it!
Patrick R. Gansterer
Comment 6 2013-11-01 03:37:56 PDT
Comment on attachment 215724 [details] A new patch View in context: https://bugs.webkit.org/attachment.cgi?id=215724&action=review > Source/WebKit/wince/WebView.cpp:454 > + focusController = m_webpage->page()->focusController(); WebCore::Page returns FocusController as a reference in the meantime (http://trac.webkit.org/browser/trunk/Source/WebCore/page/Page.h?rev=158416#L186). Please adopt your patch to the latest version.
Zhuang Zhigang
Comment 7 2013-11-03 22:05:08 PST
Created attachment 215889 [details] updated patch
Brent Fulgham
Comment 8 2013-11-19 17:49:56 PST
Comment on attachment 215889 [details] updated patch r=me.
WebKit Commit Bot
Comment 9 2013-11-19 17:52:09 PST
Comment on attachment 215889 [details] updated patch Rejecting attachment 215889 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 215889, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Working directory has changes, pass --force-clean to continue. Working directory has changes, pass --force-clean to continue. Full output: http://webkit-queues.appspot.com/results/29838005
Csaba Osztrogonác
Comment 10 2015-02-26 04:29:37 PST
There is no WinCE port long time ago.
Note You need to log in before you can comment on or make changes to this bug.