Bug 123564 - [WINCE] Focus events do not work
Summary: [WINCE] Focus events do not work
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-31 02:21 PDT by Zhuang Zhigang
Modified: 2015-02-26 04:29 PST (History)
4 users (show)

See Also:

Attachments
a patch for focus (2.05 KB, patch)
2013-10-31 02:48 PDT, Zhuang Zhigang 		no flags Details | Formatted Diff | Diff
update (2.05 KB, patch)
2013-10-31 18:09 PDT, Zhuang Zhigang 		no flags Details | Formatted Diff | Diff
A new patch (2.27 KB, patch)
2013-11-01 01:46 PDT, Zhuang Zhigang 		paroga: review-
Details | Formatted Diff | Diff
updated patch (2.06 KB, patch)
2013-11-03 22:05 PST, Zhuang Zhigang 		bfulgham: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zhuang Zhigang 2013-10-31 02:21:14 PDT 
WinCE port does not process focus events.
Comment 1 Zhuang Zhigang 2013-10-31 02:48:46 PDT 
Created attachment 215640 [details]
a patch for focus

add the process for WM_SETFOCUS and WM_KILLFOCUS in WebView::wndProc.
Comment 2 Zhuang Zhigang 2013-10-31 18:09:07 PDT 
Created attachment 215708 [details]
update
Comment 3 Patrick R. Gansterer 2013-11-01 01:08:30 PDT 
Comment on attachment 215708 [details]
update

View in context: https://bugs.webkit.org/attachment.cgi?id=215708&action=review

> Source/WebKit/wince/WebView.cpp:453
> +            focusController = m_webpage->page()->focusController();

Where is focusController declared?
Comment 4 Zhuang Zhigang 2013-11-01 01:38:32 PDT 
(In reply to comment #3)
> (From update of attachment 215708 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=215708&action=review
> 
> > Source/WebKit/wince/WebView.cpp:453
> > +            focusController = m_webpage->page()->focusController();
> 
> Where is focusController declared?
Sorry, I made a mistake. I will add the declaration of focusController and upload a new patch.
Comment 5 Zhuang Zhigang 2013-11-01 01:46:13 PDT 
Created attachment 215724 [details]
A new patch

Add declaration of FocusController. Please check it!
Comment 6 Patrick R. Gansterer 2013-11-01 03:37:56 PDT 
Comment on attachment 215724 [details]
A new patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215724&action=review

> Source/WebKit/wince/WebView.cpp:454
> +            focusController = m_webpage->page()->focusController();

WebCore::Page returns FocusController as a reference in the meantime (http://trac.webkit.org/browser/trunk/Source/WebCore/page/Page.h?rev=158416#L186). Please adopt your patch to the latest version.
Comment 7 Zhuang Zhigang 2013-11-03 22:05:08 PST 
Created attachment 215889 [details]
updated patch
Comment 8 Brent Fulgham 2013-11-19 17:49:56 PST 
Comment on attachment 215889 [details]
updated patch

r=me.
Comment 9 WebKit Commit Bot 2013-11-19 17:52:09 PST 
Comment on attachment 215889 [details]
updated patch

Rejecting attachment 215889 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 215889, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Working directory has changes, pass --force-clean to continue.
Working directory has changes, pass --force-clean to continue.

Full output: http://webkit-queues.appspot.com/results/29838005
Comment 10 Csaba Osztrogonác 2015-02-26 04:29:37 PST 
There is no WinCE port long time ago.