Bug 123563 - Remove #include from test input of the *Messages.in processing scripts
Summary: Remove #include from test input of the *Messages.in processing scripts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-31 02:02 PDT by Gergő Balogh
Modified: 2013-11-11 15:27 PST (History)
6 users (show)

See Also:

Attachments
patch (1.15 KB, patch)
2013-10-31 02:07 PDT, Gergő Balogh 		no flags Details | Formatted Diff | Diff
patch (1.14 KB, patch)
2013-11-11 07:18 PST, Gergő Balogh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gergő Balogh 2013-10-31 02:02:06 PDT 
There is some #include line left in the *.in files which could be safely removed.
Comment 1 Gergő Balogh 2013-10-31 02:07:58 PDT 
Created attachment 215633 [details]
patch
Comment 2 Anders Carlsson 2013-10-31 07:23:33 PDT 
Won't this break the unit test?
Comment 3 Gergő Balogh 2013-10-31 12:14:27 PDT 
No, the parser.py do not process #include lines only #if and #endif lines.

(In reply to comment #2)
> Won't this break the unit test?
Comment 4 Csaba Osztrogonác 2013-11-04 02:36:53 PST 
The title of the bug is misleading, because there aren't any includes
in *.messages.in files. The only useless include is in the example
input in messages_unittest.py.

It can be safely removed, because parser.py doesn't process includes at all,
as you mentioned. The patch looks good to me, but please fix the misleading
title.
Comment 5 Gergő Balogh 2013-11-11 07:18:59 PST 
Created attachment 216571 [details]
patch

Only the patch description changed.
Comment 6 Csaba Osztrogonác 2013-11-11 07:20:48 PST 
LGTM, but it needs a WK2 owner review.
Comment 7 WebKit Commit Bot 2013-11-11 15:27:16 PST 
Comment on attachment 216571 [details]
patch

Clearing flags on attachment: 216571

Committed r159075: <http://trac.webkit.org/changeset/159075>
Comment 8 WebKit Commit Bot 2013-11-11 15:27:18 PST 
All reviewed patches have been landed.  Closing bug.