Bug 123555 - REGRESSION(r158311): media/media-fragments/TC0054.html and TC0061.html hit assertions
Summary: REGRESSION(r158311): media/media-fragments/TC0054.html and TC0061.html hit as...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: LayoutTestFailure
Depends on:
Blocks:
 
Reported: 2013-10-30 21:50 PDT by Ryosuke Niwa
Modified: 2013-11-04 17:31 PST (History)
6 users (show)

See Also:


Attachments
Proposed patch (2.34 KB, patch)
2013-11-04 16:37 PST, Eric Carlson
no flags Details | Formatted Diff | Diff
Updated patch (3.62 KB, patch)
2013-11-04 16:52 PST, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Ryosuke Niwa 2013-10-30 22:01:57 PDT
Added test expectations in http://trac.webkit.org/changeset/158344.
Comment 2 Eric Carlson 2013-10-31 08:18:04 PDT
0 WTFCrash + 42 (Assertions.cpp:342)
1 WebCore::MediaFragmentURIParser::parseTimeFragment() + 316 (MediaFragmentURIParser.cpp:172)
2 WebCore::MediaFragmentURIParser::startTime() + 74 (MediaFragmentURIParser.cpp:92)

MediaFragmentURIParser.cpp:172 is:

        ASSERT(fragment.second.is8Bit());

This has been in the code since it was checked in almost two years ago. Why is it asserting now?
Comment 3 Ryosuke Niwa 2013-10-31 10:45:37 PDT
Maybe we're not creating a string in 16-bit mode?
Comment 4 Eric Carlson 2013-11-04 16:37:54 PST
Created attachment 215969 [details]
Proposed patch
Comment 5 Ryosuke Niwa 2013-11-04 16:44:08 PST
Could you also removed the test expectation I added in http://trac.webkit.org/changeset/158344 ?
Comment 6 Eric Carlson 2013-11-04 16:52:34 PST
Created attachment 215973 [details]
Updated patch
Comment 7 Eric Carlson 2013-11-04 16:52:54 PST
(In reply to comment #5)
> Could you also removed the test expectation I added in http://trac.webkit.org/changeset/158344 ?

Oops, removed in the updated patch.
Comment 8 Darin Adler 2013-11-04 17:21:03 PST
Comment on attachment 215973 [details]
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215973&action=review

> Source/WebCore/ChangeLog:12
> +            they will not processed.

not be processed
Comment 9 WebKit Commit Bot 2013-11-04 17:31:19 PST
Comment on attachment 215973 [details]
Updated patch

Clearing flags on attachment: 215973

Committed r158624: <http://trac.webkit.org/changeset/158624>
Comment 10 WebKit Commit Bot 2013-11-04 17:31:21 PST
All reviewed patches have been landed.  Closing bug.