Bug 123555 – REGRESSION(r158311): media/media-fragments/TC0054.html and TC0061.html hit assertions

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Ryosuke Niwa]

http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=media%2Fmedia-fragments%2FTC0054.html%2Cmedia%2Fmedia-fragments%2FTC0061.html

e.g.
http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r158339%20(13794)/results.html

[Ryosuke Niwa]

Added test expectations in http://trac.webkit.org/changeset/158344.

[Eric Carlson]

0 WTFCrash + 42 (Assertions.cpp:342)
1 WebCore::MediaFragmentURIParser::parseTimeFragment() + 316 (MediaFragmentURIParser.cpp:172)
2 WebCore::MediaFragmentURIParser::startTime() + 74 (MediaFragmentURIParser.cpp:92)

MediaFragmentURIParser.cpp:172 is:

        ASSERT(fragment.second.is8Bit());

This has been in the code since it was checked in almost two years ago. Why is it asserting now?

[Ryosuke Niwa]

Maybe we're not creating a string in 16-bit mode?

[Eric Carlson]

Created attachment 215969 [details]
Proposed patch

[Ryosuke Niwa]

Could you also removed the test expectation I added in http://trac.webkit.org/changeset/158344 ?

[Eric Carlson]

Created attachment 215973 [details]
Updated patch

[Eric Carlson]

(In reply to comment #5)
> Could you also removed the test expectation I added in http://trac.webkit.org/changeset/158344 ?

Oops, removed in the updated patch.

[Darin Adler]

Comment on attachment 215973 [details]
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215973&action=review

> Source/WebCore/ChangeLog:12
> +            they will not processed.

not be processed

[WebKit Commit Bot]

Comment on attachment 215973 [details]
Updated patch

Clearing flags on attachment: 215973

Committed r158624: <http://trac.webkit.org/changeset/158624>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.