Bug 123549 - Repro scrolling crash with scrollbars that use setPresentationValue on the scrolling thread
Summary: Repro scrolling crash with scrollbars that use setPresentationValue on the sc...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Beth Dakin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-10-30 19:28 PDT by Beth Dakin
Modified: 2013-10-31 14:02 PDT (History)
10 users (show)

See Also:

Attachments
Patch (1.59 KB, patch)
2013-10-30 19:32 PDT, Beth Dakin 		darin: review+
Details | Formatted Diff | Diff
Pacth (3.46 KB, patch)
2013-10-31 13:56 PDT, Beth Dakin 		beidson: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2013-10-30 19:28:09 PDT 
We're crashing in ScrollingTreeScrollingNodeMac::setScrollLayerPosition() with what appears to be a bad ScrollbarPainter.

<rdar://problem/15246606>
Comment 1 Beth Dakin 2013-10-30 19:32:29 PDT 
Created attachment 215600 [details]
Patch

Here's a speculative fix. Unfortunately I have not been able to repro this in my own build, but it is probably timing-dependent, so that might make sense.
Comment 2 Simon Fraser (smfr) 2013-10-31 10:19:04 PDT 
Beth, I think it would be good to get someone who sees the crash (e.g. Tim) to test this patch. He said it was really easy to hit.
Comment 3 Beth Dakin 2013-10-31 11:03:17 PDT 
(In reply to comment #2)
> Beth, I think it would be good to get someone who sees the crash (e.g. Tim) to test this patch. He said it was really easy to hit.

I can repro the crash easily too! But not in a debug or release build.
Comment 4 Beth Dakin 2013-10-31 11:24:49 PDT 
Committed change with http://trac.webkit.org/changeset/158375
Comment 5 Beth Dakin 2013-10-31 13:52:27 PDT 
This bug still reproduces. Attempting another speculative fix.
Comment 6 Beth Dakin 2013-10-31 13:56:00 PDT 
Created attachment 215674 [details]
Pacth

Here's another speculative fix.
Comment 7 Beth Dakin 2013-10-31 14:02:45 PDT 
http://trac.webkit.org/changeset/158391