Bug 123548 - REGRESSION(r158333): http/tests/xmlhttprequest/response-encoding.html and xmlhttprequest-overridemimetype-content-type-header.html are failing
Summary: REGRESSION(r158333): http/tests/xmlhttprequest/response-encoding.html and xml...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: XML (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: LayoutTestFailure
Depends on:
Blocks:
 
Reported: 2013-10-30 19:24 PDT by Ryosuke Niwa
Modified: 2013-10-31 09:48 PDT (History)
5 users (show)

See Also:

Attachments
proposed fix (6.06 KB, patch)
2013-10-30 23:47 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
patch updated to trunk (6.17 KB, patch)
2013-10-31 00:06 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Ryosuke Niwa 2013-10-30 19:34:21 PDT 
Committed r158338: <http://trac.webkit.org/changeset/158338>
Comment 2 Alexey Proskuryakov 2013-10-30 20:54:05 PDT 
Thank you, will look into this tonight.

In the future, please just roll out patches that break tests, decreasing test coverage is not beneficial.
Comment 3 Alexey Proskuryakov 2013-10-30 23:44:43 PDT 
This is an actual existing bug in WebCore uncovered by the added test.

Boy, is WebCore resource cache a mess...
Comment 4 Brady Eidson 2013-10-30 23:46:10 PDT 
(In reply to comment #3)
> This is an actual existing bug in WebCore uncovered by the added test.
> 
> Boy, is WebCore resource cache a mess...

Just discovering that tonight?
You're kidding, right?
Comment 5 Alexey Proskuryakov 2013-10-30 23:47:01 PDT 
Created attachment 215623 [details]
proposed fix
Comment 6 Alexey Proskuryakov 2013-10-31 00:06:54 PDT 
Created attachment 215624 [details]
patch updated to trunk
Comment 7 Ryosuke Niwa 2013-10-31 00:26:00 PDT 
(In reply to comment #3)
> This is an actual existing bug in WebCore uncovered by the added test.
> 
> Boy, is WebCore resource cache a mess...

Indeed :(
Comment 8 Brady Eidson 2013-10-31 09:18:58 PDT 
Comment on attachment 215624 [details]
patch updated to trunk

!!!
Comment 9 WebKit Commit Bot 2013-10-31 09:48:15 PDT 
Comment on attachment 215624 [details]
patch updated to trunk

Clearing flags on attachment: 215624

Committed r158362: <http://trac.webkit.org/changeset/158362>
Comment 10 WebKit Commit Bot 2013-10-31 09:48:17 PDT 
All reviewed patches have been landed.  Closing bug.