[Gtk] Missing forwarding headers after r158317
Created attachment 215580 [details] Patch
I was getting errors like: CXX Source/WebCore/bindings/js/libWebCore_la-JSDOMPromise.lo In file included from ../../Source/WebCore/bindings/js/JSDOMPromise.cpp:27:0: ../../Source/WebCore/bindings/js/JSDOMPromise.h:32:38: fatal error: JavaScriptCore/JSPromise.h: No such file or directory #include <JavaScriptCore/JSPromise.h> ^ compilation terminated. This seems to be caused by r158317, and this patch fixes it for me.
Hm, I don't know what the JSCryptoKey error is about. I saw it on my machine earlier, but I don't get it anymore.
Created attachment 215601 [details] Patch Ok, this fixes the JScryptoKey error too. I fixed it and then forgot about it, since the file stayed built.
Comment on attachment 215601 [details] Patch Rejecting attachment 215601 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 215601, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/17088423
Created attachment 215605 [details] Fix 'Oops' line
Comment on attachment 215605 [details] Fix 'Oops' line This is not the right fix, non-API forwarding headers should be in WebCore/ForwardingHeaders.
Comment on attachment 215605 [details] Fix 'Oops' line View in context: https://bugs.webkit.org/attachment.cgi?id=215605&action=review Sorry for breaking the build - EWS didn't tell me, because the build was already broken then. > Source/WebCore/GNUmakefile.list.am:153 > + DerivedSources/WebCore/JSCryptoKey.cpp \ It's OK to add the .cpp file, but not necessary - it's all ifdefed out.
Also, this part of my patch is wrong: #include <JavaScriptCore/JSGlobalObject.h> #include <JavaScriptCore/JSPromise.h> #include <JavaScriptCore/JSPromiseResolver.h> #include <JavaScriptCore/StrongInlines.h> These should be included as <runtime/JSGlobalObject.h> and so on.
Created attachment 215609 [details] Patch How about this? I had previously assumed that the #include lines were correct.
Comment on attachment 215609 [details] Patch Attachment 215609 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/17108408
From the mac build: > In file included from /Volumes/Data/EWS/WebKit/Source/WebCore/bindings/js/JSDOMPromise.cpp:27: > /Volumes/Data/EWS/WebKit/Source/WebCore/bindings/js/JSDOMPromise.h:31:10: fatal error: 'JavaScriptCore/heap/StrongInlines.h' file not found > #include <JavaScriptCore/heap/StrongInlines.h> What? :\
Comment on attachment 215609 [details] Patch Attachment 215609 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/17788112
Comment on attachment 215609 [details] Patch Attachment 215609 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/17038414
> > #include <JavaScriptCore/heap/StrongInlines.h> > > What? :\ Should be just <heap/StrongInlines.h>
Created attachment 215615 [details] Patch Oh, I see. Sorry, wasn't reading closely enough I guess. This version fixes that, but may still fail due to lack of forwarding headers. We'll see what happens.
Fixed the style of includes in <http://trac.webkit.org/r158345>. Still needs adding JSCryptoKey.h.
Created attachment 215617 [details] Just the JSCryptoKey fix
Comment on attachment 215617 [details] Just the JSCryptoKey fix Clearing flags on attachment: 215617 Committed r158347: <http://trac.webkit.org/changeset/158347>
All reviewed patches have been landed. Closing bug.