Bug 123534 - Web Inspector: Remove basic uses of InspectorState from agents
Summary: Web Inspector: Remove basic uses of InspectorState from agents
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-10-30 15:25 PDT by Joseph Pecoraro
Modified: 2013-10-30 17:24 PDT (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (67.64 KB, patch)
2013-10-30 16:12 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2013-10-30 15:25:29 PDT 
All InspectorAgents are given an InspectorState object, but we don't use the restore functionality. So we should remove the added complexity.

However, many of the agent's store legitimate state on m_state. Convert all plain data type / String InspectorState uses to member variables.

Next step will be handling the few remaining InspectorObjects.
Comment 1 Radar WebKit Bug Importer 2013-10-30 15:26:07 PDT 
<rdar://problem/15356682>
Comment 2 Joseph Pecoraro 2013-10-30 16:12:30 PDT 
Created attachment 215569 [details]
[PATCH] Proposed Fix
Comment 3 Timothy Hatcher 2013-10-30 16:59:15 PDT 
Comment on attachment 215569 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=215569&action=review

> Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp:70
>  namespace DOMDebuggerAgentState {
>  static const char eventListenerBreakpoints[] = "eventListenerBreakpoints";
> -static const char pauseOnAllXHRs[] = "pauseOnAllXHRs";
>  static const char xhrBreakpoints[] = "xhrBreakpoints";
>  }

Why can't the rest be removed?
Comment 4 WebKit Commit Bot 2013-10-30 17:24:26 PDT 
Comment on attachment 215569 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 215569

Committed r158331: <http://trac.webkit.org/changeset/158331>
Comment 5 WebKit Commit Bot 2013-10-30 17:24:27 PDT 
All reviewed patches have been landed.  Closing bug.