RESOLVED FIXED Bug 123534
Web Inspector: Remove basic uses of InspectorState from agents 
https://bugs.webkit.org/show_bug.cgi?id=123534
Summary Web Inspector: Remove basic uses of InspectorState from agents
Joseph Pecoraro
Reported 2013-10-30 15:25:29 PDT
All InspectorAgents are given an InspectorState object, but we don't use the restore functionality. So we should remove the added complexity. However, many of the agent's store legitimate state on m_state. Convert all plain data type / String InspectorState uses to member variables. Next step will be handling the few remaining InspectorObjects.
Attachments
[PATCH] Proposed Fix (67.64 KB, patch)
2013-10-30 16:12 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-10-30 15:26:07 PDT
<rdar://problem/15356682>
Joseph Pecoraro
Comment 2 2013-10-30 16:12:30 PDT
Created attachment 215569 [details] [PATCH] Proposed Fix
Timothy Hatcher
Comment 3 2013-10-30 16:59:15 PDT
Comment on attachment 215569 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=215569&action=review > Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp:70 > namespace DOMDebuggerAgentState { > static const char eventListenerBreakpoints[] = "eventListenerBreakpoints"; > -static const char pauseOnAllXHRs[] = "pauseOnAllXHRs"; > static const char xhrBreakpoints[] = "xhrBreakpoints"; > } Why can't the rest be removed?
WebKit Commit Bot
Comment 4 2013-10-30 17:24:26 PDT
Comment on attachment 215569 [details] [PATCH] Proposed Fix Clearing flags on attachment: 215569 Committed r158331: <http://trac.webkit.org/changeset/158331>
WebKit Commit Bot
Comment 5 2013-10-30 17:24:27 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.