Bug 123525 – Web Inspector: Remove InspectorAgent::restore functionality

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

No WebKit ports use / exercise  reconnect/restore functionality (InspectorController::reconnectFrontend and Inspector*Agent::restore).

We should remove this, and then also the InspectorState / cookie information saved for restoring.

[Radar WebKit Bug Importer]

<rdar://problem/15355094>

[Joseph Pecoraro]

Created attachment 215557 [details]
[PATCH] Proposed Fix

[Timothy Hatcher]

Comment on attachment 215557 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=215557&action=review

> Source/WebCore/inspector/InspectorController.cpp:-291
> -    m_state->loadFromCookie(inspectorStateCookie);

I think you can remove m_state and friends too.

[Joseph Pecoraro]

(In reply to comment #3)
> (From update of attachment 215557 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=215557&action=review
> 
> > Source/WebCore/inspector/InspectorController.cpp:-291
> > -    m_state->loadFromCookie(inspectorStateCookie);
> 
> I think you can remove m_state and friends too.

Yep, I am in the process of removing it. That is far more involved so I wanted to make the patches separate.

[WebKit Commit Bot]

Comment on attachment 215557 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 215557

Committed r158320: <http://trac.webkit.org/changeset/158320>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.