RESOLVED FIXED 123513
IDBCursorBackendLevelDB should be made cross-platform 
https://bugs.webkit.org/show_bug.cgi?id=123513
Summary IDBCursorBackendLevelDB should be made cross-platform
Brady Eidson
Reported 2013-10-30 09:29:53 PDT
IDBCursorBackendLevelDB should be made cross-platform All the refactoring except for the actual rename has already been done, so a move and rename is coming up!
Attachments
Patch v1 (36.29 KB, patch)
2013-10-30 09:41 PDT, Brady Eidson 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Patch v2 (36.29 KB, patch)
2013-10-30 10:05 PDT, Brady Eidson 		kling: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2013-10-30 09:41:14 PDT
Created attachment 215516 [details] Patch v1
Build Bot
Comment 2 2013-10-30 09:58:08 PDT
Comment on attachment 215516 [details] Patch v1 Attachment 215516 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/17148188
Brady Eidson
Comment 3 2013-10-30 10:04:57 PDT
/Volumes/Data/EWS/WebKit/Source/WebCore/Modules/indexeddb/IDBCursorBackendImpl.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/IDBCursorBackendImpl.o /Volumes/Data/EWS/WebKit/Source/WebCore/Modules/indexeddb/IDBCursorBackendImpl.cpp:31:10: fatal error: 'IDBBackingStoreLevelDB.h' file not found #include "IDBBackingStoreLevelDB.h" ^ Yup, whoops - had that locally but didn't stage it for the patch. New one coming...
Build Bot
Comment 4 2013-10-30 10:05:11 PDT
Comment on attachment 215516 [details] Patch v1 Attachment 215516 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/17138218
Brady Eidson
Comment 5 2013-10-30 10:05:30 PDT
Created attachment 215519 [details] Patch v2
Brady Eidson
Comment 6 2013-10-30 10:42:48 PDT
Changed WebCore.vcxproj to reflect the rename locally. Just waiting on gtk/efl at this point.
Build Bot
Comment 7 2013-10-30 10:45:03 PDT
Comment on attachment 215519 [details] Patch v2 Attachment 215519 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/17138228
Brady Eidson
Comment 8 2013-10-30 10:58:54 PDT
EWS are all seemingly wedged... just gonna go for it.
Brady Eidson
Comment 9 2013-10-30 11:02:23 PDT
http://trac.webkit.org/changeset/158289 Just with a bad commit message :(
Note You need to log in before you can comment on or make changes to this bug.