WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
123510
Web Inspector: Add Support for OS X Full Screen Mode
https://bugs.webkit.org/show_bug.cgi?id=123510
Summary
Web Inspector: Add Support for OS X Full Screen Mode
Carlos
Reported
2013-10-30 06:42:25 PDT
Safari's web inspector does not all for full screen mode, and should for multi-display goodness. Chrome does.
Attachments
[PATCH] Proposed Fix
(7.73 KB, patch)
2015-06-25 18:18 PDT
,
Joseph Pecoraro
timothy
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2013-10-30 06:42:36 PDT
<
rdar://problem/15350912
>
Timothy Hatcher
Comment 2
2014-02-10 13:25:32 PST
***
Bug 128529
has been marked as a duplicate of this bug. ***
Joseph Pecoraro
Comment 3
2015-06-25 18:18:41 PDT
Created
attachment 255606
[details]
[PATCH] Proposed Fix
Timothy Hatcher
Comment 4
2015-06-25 18:32:19 PDT
Comment on
attachment 255606
[details]
[PATCH] Proposed Fix View in context:
https://bugs.webkit.org/attachment.cgi?id=255606&action=review
> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:317 > + [window setCollectionBehavior:([window collectionBehavior] | NSWindowCollectionBehaviorFullScreenPrimary)];
Why Primary here and NSWindowCollectionBehaviorFullScreenAllowsTiling above?
Joseph Pecoraro
Comment 5
2015-06-25 18:41:45 PDT
Comment on
attachment 255606
[details]
[PATCH] Proposed Fix View in context:
https://bugs.webkit.org/attachment.cgi?id=255606&action=review
>> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:317 >> + [window setCollectionBehavior:([window collectionBehavior] | NSWindowCollectionBehaviorFullScreenPrimary)]; > > Why Primary here and NSWindowCollectionBehaviorFullScreenAllowsTiling above?
This adds Primary, and then ~5 lines later it adds NSWindowCollectionBehaviorFullScreenAllowsTiling. Both WK1 and WK2 are adding both collection behaviors.
Joseph Pecoraro
Comment 6
2015-06-25 18:47:21 PDT
http://trac.webkit.org/changeset/185978
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug