Building webkitgtk+ 2.3.1 with GCC 4.8 While compiling Source/WebKit2/Shared/WebKeyboardEvent.cpp I've got: In file included from ../Source/WebKit2/Shared/WebCoreArgumentCoders.h:29:0, from ../Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:27: ../Source/WebKit2/Platform/CoreIPC/ArgumentCoders.h: In instantiation of 'static void CoreIPC::SimpleArgumentCoder<T>::encode(CoreIPC::ArgumentEncoder&, const T&) [with T = WebCore::TransformationMatrix]': ../Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:77:48: required from here ../Source/WebKit2/Platform/CoreIPC/ArgumentCoders.h:42:83: error: invalid application of 'sizeof' to incomplete type 'WebCore::TransformationMatrix' encoder.encodeFixedLengthData(reinterpret_cast<const uint8_t*>(&t), sizeof(T), __alignof(T)); ^ ../Source/WebKit2/Platform/CoreIPC/ArgumentCoders.h:42:100: error: invalid application of '__alignof__' to incomplete type 'WebCore::TransformationMatrix' encoder.encodeFixedLengthData(reinterpret_cast<const uint8_t*>(&t), sizeof(T), __alignof(T)); ^ ../Source/WebKit2/Platform/CoreIPC/ArgumentCoders.h: In instantiation of 'static bool CoreIPC::SimpleArgumentCoder<T>::decode(CoreIPC::ArgumentDecoder&, T&) [with T = WebCore::TransformationMatrix]': ../Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:82:55: required from here ../Source/WebKit2/Platform/CoreIPC/ArgumentCoders.h:47:84: error: invalid application of 'sizeof' to incomplete type 'WebCore::TransformationMatrix' return decoder.decodeFixedLengthData(reinterpret_cast<uint8_t*>(&t), sizeof(T), __alignof(T)); ^ ../Source/WebKit2/Platform/CoreIPC/ArgumentCoders.h:47:101: error: invalid application of '__alignof__' to incomplete type 'WebCore::TransformationMatrix' return decoder.decodeFixedLengthData(reinterpret_cast<uint8_t*>(&t), sizeof(T), __alignof(T)); ^ ../Source/WebKit2/Platform/CoreIPC/ArgumentCoders.h: In instantiation of 'static void CoreIPC::SimpleArgumentCoder<T>::encode(CoreIPC::ArgumentEncoder&, const T&) [with T = WebCore::FloatPoint3D]': ../Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:99:40: required from here ../Source/WebKit2/Platform/CoreIPC/ArgumentCoders.h:42:83: error: invalid application of 'sizeof' to incomplete type 'WebCore::FloatPoint3D' encoder.encodeFixedLengthData(reinterpret_cast<const uint8_t*>(&t), sizeof(T), __alignof(T)); ^ ../Source/WebKit2/Platform/CoreIPC/ArgumentCoders.h:42:100: error: invalid application of '__alignof__' to incomplete type 'WebCore::FloatPoint3D' encoder.encodeFixedLengthData(reinterpret_cast<const uint8_t*>(&t), sizeof(T), __alignof(T)); ^ ../Source/WebKit2/Platform/CoreIPC/ArgumentCoders.h: In instantiation of 'static bool CoreIPC::SimpleArgumentCoder<T>::decode(CoreIPC::ArgumentDecoder&, T&) [with T = WebCore::FloatPoint3D]': ../Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:104:47: required from here ../Source/WebKit2/Platform/CoreIPC/ArgumentCoders.h:47:84: error: invalid application of 'sizeof' to incomplete type 'WebCore::FloatPoint3D' return decoder.decodeFixedLengthData(reinterpret_cast<uint8_t*>(&t), sizeof(T), __alignof(T)); ^ ../Source/WebKit2/Platform/CoreIPC/ArgumentCoders.h:47:101: error: invalid application of '__alignof__' to incomplete type 'WebCore::FloatPoint3D' return decoder.decodeFixedLengthData(reinterpret_cast<uint8_t*>(&t), sizeof(T), __alignof(T)); ^
Can you please attach the config.log file?
Created attachment 215637 [details] config.log of build failing Hi Zan! I have the same problem on my machine. Could you please see my config.log. Br, Vitaly
Created attachment 215639 [details] diff to fix build failing Zan, this patch fixes the build problem. Please review it. Br, Vitaly
Attachment 215639 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/Shared/WebCoreArgumentCoders.cpp']" exit_code: 1 Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:56: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style.
The patch looks OK, but requires a ChangeLog entry. The style error should also be addressed. More on what tools to use to produce the ChangeLog here: http://www.webkit.org/coding/contributing.html
Created attachment 215644 [details] Patch
Comment on attachment 215644 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215644&action=review > Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:28 > +#include <WebCore/TransformationMatrix.h> I think this should be added below, not here, right after #include <WebCore/TextCheckerClient.h>
Created attachment 215647 [details] Patch
(In reply to comment #7) Carlos, thank you for review. Done. > (From update of attachment 215644 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=215644&action=review > > > Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:28 > > +#include <WebCore/TransformationMatrix.h> > > I think this should be added below, not here, right after #include <WebCore/TextCheckerClient.h>
Gentlemen, can anybody with commit-privileges commit changes? Thanks in advance! Br, Vitaly
Comment on attachment 215647 [details] Patch Clearing flags on attachment: 215647 Committed r158486: <http://trac.webkit.org/changeset/158486>
All reviewed patches have been landed. Closing bug.
Comment on attachment 215639 [details] diff to fix build failing Cleared review? from attachment 215639 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).