Bug 123496 – Unguard Element::childShouldCreateRenderer

• Status: RESOLVED
• Resolution: FIXED
• Component: MathML

[ChangSeok Oh]

The declaration of 1Element::childShouldCreateRenderer is guarded with MATHML and SVG.
But it causes a link error when disabling svg because of missing MATHML flag for the definition of Element::childShouldCreateRenderer.
Even we add a MATHML flag for it, you would face a compile error caused by SVGNames. we could avoid it like following but I think it's an abuse of flags.

#if ENABLE(SVG) || ENABLE(MATHML)
bool Element::childShouldCreateRenderer(const Node* child) const
{
#if ENABLE(SVG)
    // Only create renderers for SVG elements whose parents are SVG elements, or for proper <svg xmlns="svgNS"> subdocuments.                                                    
    if (child->isSVGElement())
        return child->hasTagName(SVGNames::svgTag) || isSVGElement();
#endif
    return ContainerNode::childShouldCreateRenderer(child);
}

So I propose removing the two guards from Element::childShouldCreateRenderer. I believe there would be no harm.

[ChangSeok Oh]

Created attachment 215477 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 215477 [details]
Patch

Clearing flags on attachment: 215477

Committed r158275: <http://trac.webkit.org/changeset/158275>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.