We should remove dead code
<rdar://problem/15347544>
It doesn't look like we use WebDrawText anymore, and the one client program that had been using it no longer needs it. This bug removes the unused code as well as the exported symbol.
Created attachment 215544 [details] Patch
Comment on attachment 215544 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215544&action=review Looks good, but you also need to tell Visual Studio to NOT look for the removed symbol when building the DLL. > Source/WebKit/win/WebKitGraphics.h:-66 > -void WebDrawText(WebTextRenderInfo*); This also needs to be removed from WebKitExports.def.in
Created attachment 215545 [details] Patch
Comment on attachment 215545 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215545&action=review Sorry -- I missed one thing, and we need a ChangeLog on the "WebKitExports.def.in" change. > Source/WebKit/win/ChangeLog:8 > + * WebKitGraphics.cpp: You should say something like "Removed unused WebDrawText implementation." > Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:-14 > - WebDrawText Unfortunately, this file is in the scope of "Source/WebKit/ChangeLog" (not just the "Source/WebKit/win/ChangeLog"), so yet ANOTHER ChangeLog is needed. "prepare-ChangeLog" should get it set up properly for you.
Created attachment 215546 [details] Patch
Created attachment 215547 [details] Patch
Comment on attachment 215547 [details] Patch r=me.
Comment on attachment 215547 [details] Patch Rejecting attachment 215547 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 215547, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/17038284
Created attachment 215550 [details] Patch
Comment on attachment 215550 [details] Patch Try again! r=me
Comment on attachment 215550 [details] Patch Clearing flags on attachment: 215550 Committed r158309: <http://trac.webkit.org/changeset/158309>
All reviewed patches have been landed. Closing bug.