Bug 123476 - Add bindings code for crypto algorithm dictionaries
Summary: Add bindings code for crypto algorithm dictionaries
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
Depends on:
Blocks: 122679
  Show dependency treegraph
Reported: 2013-10-29 15:49 PDT by Alexey Proskuryakov
Modified: 2013-10-31 10:38 PDT (History)
3 users (show)

See Also:

proposed patch (40.83 KB, patch)
2013-10-29 16:07 PDT, Alexey Proskuryakov
sam: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-10-29 15:49:50 PDT
We need to convert Algorithm dictionaries to C++ structs/classes, so that we could pass them to DOM code.

This is somewhat complicated due to incompatibilities between Web IDL and WebCrypto (e.g. WebCrypto uses nested dictionaries, which is not allowed, and it also doesn't describe what exactly to do with missing dictionary elements).
Comment 1 Alexey Proskuryakov 2013-10-29 16:07:53 PDT
Created attachment 215440 [details]
proposed patch

Will fail to compile, because it depends on other patches. But the code is all disabled anyway, so EWS is not of much use.
Comment 2 Build Bot 2013-10-29 16:10:50 PDT
Comment on attachment 215440 [details]
proposed patch

Attachment 215440 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/17148147
Comment 3 Alexey Proskuryakov 2013-10-31 10:31:31 PDT
Committed <http://trac.webkit.org/r158366>.
Comment 4 Alexey Proskuryakov 2013-10-31 10:38:26 PDT
Follow-up in <http://trac.webkit.org/r158367>.